Pixmap optimizations #402
Merged
Pixmap optimizations #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's just nicer and safer to use.
Pixmaps icons properties may be huge arrays of arrays of bytes, unpacking them could be expensive and most likely unneeded. We did this in the past as it made easy to handle the properties, but it's time to change this, so always use the variants as they are extracting the child values of the arrays to perform size comparisons, until we actually need the bytes to perform the RGBA conversion.
So that could be reused by other files
This is very likely happening automatically if destruction happens because the name has been lost, but in case that's not the case, let's cleanup the stuff before the js GC will remove the whole proxy.
We used to keep the pixmaps variants saved as cached properties of the proxy but these are just a waste of memory usage once the icon is set, given that we're not going to re-use them as they are in any case until the icon is invalidated which happens only in rare cases. So, once a pixmap is set, unset the cached property and mark it as invalid, in this way next time an icon is requested we can refresh it if that's required
3v1n0
force-pushed
the
pixmap-optimizations
branch
from
0516da6
to
091fbae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize various cases when pixmap icons are used, so that we can reduce their memory impact and do less operations, avoiding to unpack the variants we don't care about.