appIndicator Use Clutter to load RGBA Pixmap textures natively #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid doing the conversion JS, as Clutter can handle this natively. In case we don't have overlays (and then we don't need to create an emblemed icon), we can avoid going through reading the texture, but just leave to clutter the role of painting the ImageContent as it is. Closes: #295
We don't need to create a child actor, we can just reuse the same logic we now use for pixmaps.
3v1n0
force-pushed
the
pixmaps-as-image-content
branch
from
c28d554
to
ed8a043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid doing the conversion JS, as Clutter can handle this natively.
In case we don't have overlays (and then we don't need to create an emblemed
icon), we can avoid going through reading the texture, but just leave to
clutter the role of painting the ImageContent as it is.
Closes: #295