Lazier init #417
Merged
Lazier init #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid performing multiple requests by cancelling previously received ones
Creating menu items and populating them can be quite expensive in GNOME shell, since we may create many of them during the extension initialization we could end up blocking the UI. To avoid this, we can create multiple idles for each menu addition, one with each priority that depends on the number of elements already queued for addition, in this way the items are added in different main loop idle cycles avoiding to fill our job queue with too many things to do each frame. Helps with: #295
They may be added to the set in case they match service name
We can avoid doing it later by just not exposing the interfaces at all
No need to wait for hanging services forever, let's limit this to 5 seconds
We need to do chunked requests to avoid initialization slowdowns, and apparently awaiting many promises here is not as good as expected and may lead to hanging, while using a generator is better, so let's do this. This implies bumping the required eslint version, while the the minimum shell version should be ok, because gjs in GNOME 3.34 required mozjs60, while async generators are supported since mozjs55. Helps with: #295
We're already depending on promises that implies going waiting anyways, so we can avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to reduce some initialization sync code that may lead to blocking UI.