-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance importer/exporter #1561
base: dev/10.3.0
Are you sure you want to change the base?
Instance importer/exporter #1561
Conversation
…nce-import-export
…ance-import-export
Overall, awesome start on this feature 👍 Some initial thoughts:
|
…nstance-import-export
That's a good point. "Export Qset" simply exports the qset with no assets attached while "Export All" will. I think this could be explained in the intermediate modal. Even so, uploading assets to a new system would likely change the IDs, rendering the qset image ids useless. I would like to enable instance+media transfer between systems, so I'll look into this.
I was worried about the wording here as well. I like that idea and think it will clarify things for the user.
If you think I should make it a different color (like the orange) to make it stand out more, I can do that. My intention here was to make it slightly more hidden since it's not widely-used as you said, and I see it as more of an advanced option.
👍🏻
Haha, good catch! Also, sorry for taking so long to respond. |
This PR adds an instance importer/exporter to a few components:
Second Iteration
Save History:
User Managed Instances/Admin Instance Search:
Toast:
First Iteration (Meatball Menu)
My Widgets Page:
Details
Media exporting works for new and updated widgets only and will not appear for widgets with missing entries in the
map_asset_to_object
table. This table was not being properly updated inWidget_Question::db_store
(NEEDS CHECK ON PROD).Details:
apiGetQuestionSet
andapiGetWidgetInstance
to use object syntax for parametersWhile I don't see a use case for importing media in Materia itself (since we're just pointing at already existing assets), this is something that would most likely need to be added in the Materia Community Library.
To do:
Fix import instance button styling?Reduce/reword export option menu items?Certain widgets store media assets in other locations such as Labeling. Add these assets to themap_asset_to_object
table as well through a recursive search