The doxygen comments have been added for all files. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a few compiling issues with gfortran. Fixed a bug in dual time stepping loop counter.
Antonis-F
reviewed
Apr 23, 2020
| F90=mpiifort | ||
|
|
There was a problem hiding this comment.
nice, what about passing the option of type of compiler through as argument
i.e. intel, gcc etc
see here
https://stackoverflow.com/a/2826178/4679900
There was a problem hiding this comment.
i guess eventually would be nice to have a separate config step and then we do make all or something 😄
| if (ielem(n,i)%interior.eq.1)then !THAT HAVE AT LEAST ONE UNKNWON NEIGHBOUR | ||
| IF (ielem(n,i)%nofbc.GT.0)THEN !THAT HAVE AT LEAST ESTABLISHED A BOUNDARY CONDITION CODE | ||
| DO J=1,ielem(n,i)%IFCA !LOOP ALL THEIR BOUNDARY FACES | ||
| DO I=1,KMAXE !> ALL ELEMENTS |
There was a problem hiding this comment.
is doxygen convention to have inline comments rather than top of the function/subroutine ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few compiling issues with gfortran.
Fixed a bug in dual time stepping loop counter.