-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODESolver: Added pre and post iteration hooks #1100
Conversation
sys.assembleMatricesPicard(x_new); | ||
sys.preIteration(iteration, x); | ||
|
||
sys.assembleMatricesPicard(x); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is assembleMatricesPicard
now called with x
and not with x_new
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At that point those two vectors have exactly the same values. But I think it is more natural to call the assembly with something old (x) and not with something to be computed (x_new).
That's also more consistent with the Newton case.
Sorry for the big change, but I noticed that the pre and post iteration hooks must be put in the |
👍 |
} | ||
else | ||
{ | ||
// TODO could be solved in a better way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are many todos (in this PR also the merged PR), I think it is better to use doxygen command \todo
, which can generates a todo list, to remind one what have to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change all TODO tags to \todo in a separate PR, and then all at once for all of OGS6, if that's important.
👍 |
Looks OK. |
ODESolver: Added pre and post iteration hooks
Sorry, I forgot to check that I had to squash commits before merging. |
OpenGeoSys development has been moved to GitLab. |
Said hooks are called before and after each iteration of the nonlinear solver.
I need that functionality for TES in order to be able to drop some nonsensible iteration results.