Extrapolation of integration point values to nodes #1145

chleh · 2016-04-16T14:38:36Z

Follow-up of #1161.

This PR now compiles also with PETSc. However, I think it currently does not make sense to make it also run with PETSc, there are simply too many odds and ends, e.g.:

we cannot write to ghost nodes and sum up ghost nodes etc.
the unit test fails because NodePartitionedMesh is hard-wired into MeshComponentMap for the PETSc build.

Future work will also be to extend the extrapolator to multi-component variables.

The files related to this PR are all in NumLib/Extrapolation and Tests/Numlib
I think it's best to wait with the review until #1161 is merged and this branch is rebased.

In the meantime the unit test will give you an impression how the interpolation looks like from the user side: https://github.com/chleh/ogs6/blob/extrapol/Tests/NumLib/TestExtrapolation.cpp
Soon there will be a further PR connecting the Extrapolator to the Process.

Note: With this PR the LocalLinearLeastSquaresExtrapolator from NumLib uses SerialExecutor from AssemblerLib.

ogsbot · 2016-04-16T14:42:26Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1608/

ogsbot · 2016-04-16T14:45:08Z

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/1576/

ogsbot · 2016-04-16T14:47:13Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1490/

ogsbot · 2016-04-16T14:51:09Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1466/

ogsbot · 2016-04-17T09:39:36Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1609/

ogsbot · 2016-04-17T09:54:11Z

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/1471/

wenqing · 2016-04-18T08:24:01Z

NumLib/Extrapolation/LocalLinearLeastSquaresExtrapolator-impl.h

+    // TODO: for now always zeroth component is used
+    auto const& indices = _local_to_global(element_index, 0).rows;
+
+    _nodal_values.add(indices, tmp); // TODO does that give rise to PETSc problems?


For the current node wise partitioning, it is Ok.

My comment was more related to negative indices. I think, they will pose some problems.

ogsbot · 2016-04-21T12:58:35Z

Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/1541/

ogsbot · 2016-04-21T13:02:35Z

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/1626/

ogsbot · 2016-04-21T13:08:11Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1655/

ogsbot · 2016-04-21T13:29:56Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1533/

ogsbot · 2016-04-21T13:41:26Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1511/

endJunction · 2016-04-24T12:09:39Z

This needs a presentation/review/discussion round table meeting (PRDRTM for short)

endJunction · 2016-04-24T12:26:07Z

Extrapolator.h lacks copyright header. Please check all other files too.
Also the include guards' names do not correspond to dir/file, but this is not so important... ✅

chleh · 2016-04-24T13:25:45Z

PRDRTM is a bad acronym: You cannot read it as a word.
Can we make the PRDRTM tomorrow (i.e., on monday)?

endJunction · 2016-04-25T09:34:49Z

Tests/NumLib/TestExtrapolation.cpp

+        // Passing _dof_table works, because this process has only one variable
+        // and the variable has exactly one component.
+        _extrapolator.reset(new ExtrapolatorImplementation(
+            { 0u, 0u, nullptr, _dof_table.get(), &mesh }));


Improve matrix spec ctor.

&mesh -> nullptr.

Improve matrix spec ctor.

@endJunction, you could do that when resolving the dependency of matrix specs on the doftable.

ogsbot · 2016-04-25T09:53:39Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1558/

endJunction · 2016-04-25T10:01:24Z

NumLib/Extrapolation/LocalLinearLeastSquaresExtrapolator-impl.h

+    // counts the writes to each nodal value, i.e., the summands in order to
+    // compute the average afterwards
+    auto counts =
+        MathLib::MatrixVectorTraits<GlobalVector>::newInstance(_nodal_values);


Get count information from the DOF table, no need for an extra vector.

I don't see instantly, how I can get the number of neighbouring elements to a node directly from the dof table. Please tell me.
If it is currently not possible, I'd suggest to keep my code as it is.

There is LocalToGlobalIndexMap::getNumElementDOF() but we need the other way around relation. Keep it for now...

endJunction · 2016-04-25T10:06:19Z

NumLib/Extrapolation/LocalLinearLeastSquaresExtrapolator-impl.h

+                   GlobalVector& counts
+        )
+{
+    auto const& gp_vals = loc_asm.getIntegrationPointValues(


better names. ✅

ogsbot · 2016-04-25T10:09:35Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1536/

endJunction · 2016-04-25T10:10:37Z

NumLib/Extrapolation/LocalLinearLeastSquaresExtrapolator-impl.h

+    Eigen::VectorXd tmp = (N*N.transpose()).ldlt().solve(N*gpvs);
+
+    // TODO: for now always zeroth component is used
+    auto const& indices = _local_to_global(element_index, 0).rows;


global indices. ✅

ogsbot · 2016-04-25T14:57:29Z

Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/1574/

ogsbot · 2016-04-25T14:59:22Z

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/1659/

ogsbot · 2016-04-25T14:59:35Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1689/

ogsbot · 2016-04-25T15:11:08Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1567/

ogsbot · 2016-04-25T15:16:33Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1544/

ogsbot · 2016-04-25T22:26:52Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1570/

ogsbot · 2016-04-25T22:31:31Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1547/

TomFischer · 2016-04-26T12:05:21Z

👍

wenqing · 2016-04-27T08:32:59Z

👍

ogsbot · 2020-06-19T12:26:49Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

chleh added the WIP 🏗️ label Apr 16, 2016

chleh force-pushed the extrapol branch from cca358e to 1cd8f9d Compare April 17, 2016 09:43

wenqing reviewed Apr 18, 2016
View reviewed changes

chleh mentioned this pull request Apr 23, 2016

Misc changes #1161

Merged

chleh force-pushed the extrapol branch from 8bdb0ab to cb15cc1 Compare April 23, 2016 23:58

chleh added please review and removed WIP 🏗️ please review labels Apr 23, 2016

endJunction reviewed Apr 25, 2016
View reviewed changes

chleh force-pushed the extrapol branch from cb15cc1 to 6367a48 Compare April 25, 2016 14:53

chleh force-pushed the extrapol branch from 6367a48 to eb8b34a Compare April 25, 2016 22:18

TomFischer added the please rebase label Apr 27, 2016

chleh added 2 commits April 28, 2016 10:14

[NL] added elementwise linear least squares extrapolation

c966288

[T] added Test for Extrapolator

dda3453

chleh force-pushed the extrapol branch from 613ce43 to dda3453 Compare April 28, 2016 08:15

chleh merged commit e754b2a into ufz:master Apr 28, 2016

chleh deleted the extrapol branch April 28, 2016 08:38

chleh removed the please rebase label Apr 28, 2016

Extrapolation of integration point values to nodes #1145

Extrapolation of integration point values to nodes #1145

Conversation

chleh commented Apr 16, 2016 • edited Loading

ogsbot commented Apr 16, 2016

ogsbot commented Apr 16, 2016

ogsbot commented Apr 16, 2016

ogsbot commented Apr 16, 2016

ogsbot commented Apr 17, 2016

ogsbot commented Apr 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogsbot commented Apr 21, 2016

ogsbot commented Apr 21, 2016

ogsbot commented Apr 21, 2016

ogsbot commented Apr 21, 2016

ogsbot commented Apr 21, 2016

endJunction commented Apr 24, 2016

endJunction commented Apr 24, 2016 • edited by chleh Loading

chleh commented Apr 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogsbot commented Apr 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction Apr 25, 2016 • edited by chleh Loading

Choose a reason for hiding this comment

ogsbot commented Apr 25, 2016

endJunction Apr 25, 2016 • edited by chleh Loading

Choose a reason for hiding this comment

ogsbot commented Apr 25, 2016

ogsbot commented Apr 25, 2016

ogsbot commented Apr 25, 2016

ogsbot commented Apr 25, 2016

ogsbot commented Apr 25, 2016

ogsbot commented Apr 25, 2016

ogsbot commented Apr 25, 2016

TomFischer commented Apr 26, 2016

wenqing commented Apr 27, 2016

ogsbot commented Jun 19, 2020

chleh commented Apr 16, 2016 •

edited

Loading

endJunction commented Apr 24, 2016 •

edited by chleh

Loading

endJunction Apr 25, 2016 •

edited by chleh

Loading

endJunction Apr 25, 2016 •

edited by chleh

Loading