TES process #1181

chleh · 2016-05-01T15:36:30Z

Finally, this is the TES process PR.
Follow-up of

* [ ] #1193

hydromarc · 2016-05-03T07:55:40Z

👍 :)

chleh · 2016-05-24T06:59:27Z

Jenkins, test this please.

ogsbot · 2016-05-24T07:19:53Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1897/

ogsbot · 2016-05-24T07:20:31Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/121/

ogsbot · 2016-05-24T15:58:39Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1901/

ogsbot · 2016-05-24T15:58:43Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/125/

chleh · 2016-05-25T06:42:52Z

Jenkins, test this please.

ogsbot · 2016-05-25T07:34:36Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1788/

ogsbot · 2016-05-25T11:52:15Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/139/

ogsbot · 2016-05-25T12:14:36Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/140/

ogsbot · 2016-05-25T12:36:45Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/142/

bilke · 2016-05-25T14:17:33Z

I had to manually abort the Jenkins jobs as they were hanging..

TomFischer · 2016-05-26T07:55:04Z

ProcessLib/VariableTransformation.h

@@ -0,0 +1,87 @@
+/**
+ * \copyright
+ * Copyright (c) 2012-2015, OpenGeoSys Community (http://www.opengeosys.org)


Please update: 2012-2016 ✅

chleh · 2016-05-27T10:31:47Z

ProcessLib/TES/TESLocalAssemblerInner.cpp

+    LocalAssemblerTraits<ShapeMatrixPolicyType<void, 0>, 0, 0, 0>>;
+
+static_assert(OGS_EIGEN_DYNAMIC_SHAPE_MATRICES_FLAG == 1,
+              "inconsistent use of macros");


Todo code already present in header
EDIT: Just noticed that the code is slightly different from the header (extern template vs. template).

endJunction · 2016-05-29T15:10:28Z

So the compilation works and there is some sort of test now.
Would you please squash the commits for newly added files and clang-format them to achieve some sort of alignment/formatting consistency? Then I would say it can be merged.

chleh · 2016-05-30T06:39:24Z

Clang-format already done. I'll squash upon "rebase and merge" label.

endJunction · 2016-05-30T07:46:34Z

ProcessLib/TES/CMakeLists.txt

@@ -0,0 +1,11 @@
+if(OGS_EIGEN_DYNAMIC_SHAPE_MATRICES)
+	configure_file(


Not sure about the config files, but I also formatted them to be w/o tabs in the other PR. ✅

ogsbot · 2016-05-30T09:48:28Z

Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/1835/

wenqing · 2016-05-30T12:08:49Z

ProcessLib/TES/TESAssemblyParams.h

+
+    double rho_SR_dry = std::numeric_limits<double>::quiet_NaN();
+
+    const double M_inert = M_N2;  // N2


What is the purpose of declaring M_N2 and M_H2O outside this struct, and then assigning them to these new variables?

In the future one could extend this process to other adsorption working pairs, e.g. zeolite/ammonia. I think, we soon should introduce a physical constants namespace like we did in OGS5. In the meantime I'd like to keep these assignments as is.

ogsbot · 2016-05-30T12:15:04Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/179/

endJunction · 2016-05-30T12:16:35Z

@chleh I've aborted the linux-prs-dynamic job. It compiled and run, but the 1D tes-1D-1000elem-zeolite-discharge.prj took now around 150min runtime, which is too long for the not-LARGE ctests...

wenqing · 2016-05-30T12:29:25Z

ProcessLib/TES/TESLocalAssemblerInner-impl.h

+        (Traits::blockDimDim(laplaceCoeffMat, 0, 0, D, D) *
+         (smDNdx * Eigen::Map<const typename Traits::Vector1Comp>(localX.data(),
+                                                                  N)  // grad_p
+          /


lines 306--308 can be one line.

It's automatically formatted by clang-format and difficult to get it consistently formatted into an 80 char bound simply because the Eigen::Map...(..,N) subexpression is very long.

Thanks for explanation.

endJunction · 2016-05-30T15:49:31Z

Now it runs around 99% of speed of light (when cooled sufficiently) ;)

* less privacy * multiple process variables

ogsbot · 2016-05-30T16:20:54Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/184/

ogsbot · 2016-05-30T16:21:49Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1960/

ogsbot · 2016-05-30T18:04:23Z

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1833/

chleh · 2016-05-31T06:34:11Z

Jenkins, test this please.

endJunction · 2016-05-31T10:17:36Z

@chleh Could you please have a look onto clang-sanitizer build https://svn.ufz.de:8443/view/OGS-6%20Monitor/job/OGS-6/job/Docker/job/clang-sanitizer/218/ . It seems the TES ctest could not write output file...

ogsbot · 2020-06-19T12:28:10Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

chleh added WIP 🏗️ stop review 🛑 labels May 1, 2016

chleh force-pushed the tes-for-pr branch from 0545938 to 3e5fbef Compare May 11, 2016 22:16

chleh removed stop review 🛑 WIP 🏗️ labels May 13, 2016

chleh force-pushed the tes-for-pr branch 2 times, most recently from 5b140d6 to 1bf2013 Compare May 24, 2016 15:56

chleh force-pushed the tes-for-pr branch from c7b7726 to 767e2a4 Compare May 25, 2016 09:20

chleh added the please review label May 25, 2016

TomFischer reviewed May 26, 2016
View reviewed changes

chleh reviewed May 27, 2016
View reviewed changes

endJunction reviewed May 30, 2016
View reviewed changes

TomFischer added please rebase and removed please review labels May 30, 2016

wenqing reviewed May 30, 2016
View reviewed changes

chleh added 3 commits May 30, 2016 18:11

[PL] made Process ready for TES

cbdab2a

* less privacy * multiple process variables

[PL] added TES process

2bd86ef

[PL] added var trafo class

f2f6281

chleh force-pushed the tes-for-pr branch from 8378204 to 41d76b6 Compare May 30, 2016 16:15

chleh force-pushed the tes-for-pr branch from 41d76b6 to 73155d3 Compare May 30, 2016 17:39

chleh added 3 commits May 30, 2016 19:43

[Data] tests for TES added

109de57

[App] added TES end-to-end tests

ffa1165

[App] added error return code to OGS

1d59ee7

chleh force-pushed the tes-for-pr branch from 73155d3 to 1d59ee7 Compare May 30, 2016 17:44

chleh merged commit 87307b8 into ufz:master May 31, 2016

chleh removed the please rebase label May 31, 2016

chleh deleted the tes-for-pr branch May 31, 2016 07:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TES process #1181

TES process #1181

chleh commented May 1, 2016 •

edited

Loading

hydromarc commented May 3, 2016

chleh commented May 24, 2016

ogsbot commented May 24, 2016

ogsbot commented May 24, 2016

ogsbot commented May 24, 2016

ogsbot commented May 24, 2016

chleh commented May 25, 2016

ogsbot commented May 25, 2016

ogsbot commented May 25, 2016

ogsbot commented May 25, 2016

ogsbot commented May 25, 2016

bilke commented May 25, 2016

TomFischer May 26, 2016 •

edited by chleh

Loading

chleh May 27, 2016 •

edited

Loading

endJunction commented May 29, 2016

chleh commented May 30, 2016

endJunction May 30, 2016 •

edited by chleh

Loading

ogsbot commented May 30, 2016

wenqing May 30, 2016

chleh May 30, 2016

wenqing May 30, 2016

ogsbot commented May 30, 2016

endJunction commented May 30, 2016

wenqing May 30, 2016

endJunction May 30, 2016

wenqing May 30, 2016

endJunction commented May 30, 2016

ogsbot commented May 30, 2016

ogsbot commented May 30, 2016

ogsbot commented May 30, 2016

chleh commented May 31, 2016

endJunction commented May 31, 2016

ogsbot commented Jun 19, 2020

		@@ -0,0 +1,11 @@
		if(OGS_EIGEN_DYNAMIC_SHAPE_MATRICES)
		configure_file(


		double rho_SR_dry = std::numeric_limits<double>::quiet_NaN();

		const double M_inert = M_N2; // N2

TES process #1181

TES process #1181

Conversation

chleh commented May 1, 2016 • edited Loading

hydromarc commented May 3, 2016

chleh commented May 24, 2016

ogsbot commented May 24, 2016

ogsbot commented May 24, 2016

ogsbot commented May 24, 2016

ogsbot commented May 24, 2016

chleh commented May 25, 2016

ogsbot commented May 25, 2016

ogsbot commented May 25, 2016

ogsbot commented May 25, 2016

ogsbot commented May 25, 2016

bilke commented May 25, 2016

TomFischer May 26, 2016 • edited by chleh Loading

Choose a reason for hiding this comment

chleh May 27, 2016 • edited Loading

Choose a reason for hiding this comment

endJunction commented May 29, 2016

chleh commented May 30, 2016

endJunction May 30, 2016 • edited by chleh Loading

Choose a reason for hiding this comment

ogsbot commented May 30, 2016

wenqing May 30, 2016

Choose a reason for hiding this comment

chleh May 30, 2016

Choose a reason for hiding this comment

wenqing May 30, 2016

Choose a reason for hiding this comment

ogsbot commented May 30, 2016

endJunction commented May 30, 2016

wenqing May 30, 2016

Choose a reason for hiding this comment

endJunction May 30, 2016

Choose a reason for hiding this comment

wenqing May 30, 2016

Choose a reason for hiding this comment

endJunction commented May 30, 2016

ogsbot commented May 30, 2016

ogsbot commented May 30, 2016

ogsbot commented May 30, 2016

chleh commented May 31, 2016

endJunction commented May 31, 2016

ogsbot commented Jun 19, 2020

chleh commented May 1, 2016 •

edited

Loading

TomFischer May 26, 2016 •

edited by chleh

Loading

chleh May 27, 2016 •

edited

Loading

endJunction May 30, 2016 •

edited by chleh

Loading