Disallow 32-bit Windows builds. #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be forced by setting OGS_32_BIT=ON
|
⏩ |
|
Looks good. 👍 |
|
👍 You could also disallow 32 bit builds on other platforms, or are they supported better on, e.g. linux? |
|
On Linux-based platforms it is much harder to configure for 32-bit so in this case I assume the person knows what he is doing... |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be forced by setting
OGS_32_BIT=ON.In general Windows 32-bit builds are not supported but often are accidentally configured (because CMake defaults to a 32-bit generator). Beside running OGS on Win XP there is no reason to build for 32-bit Windows.