-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GL] Impl. of copy constructor of Surface and minor improvements #1237
Conversation
TomFischer
commented
Jun 3, 2016
- Impl. of Surface copy construtor
- Cleanup unused code
- Clang format
- Make classes Triangle and Surface final
- Readability improvements
/// return a geometry type | ||
virtual GEOTYPE getGeoType() const {return GEOTYPE::SURFACE;} | ||
Surface(Surface && src) = delete; | ||
Surface& operator=(Surface const& src) = delete; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there reasons not to implement the copy assignment? If not I'd suggest to implement it too along with the copy ctor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented the copy constructor since @rinkk needs it. The only reason the move constructor and the assignment and assignment move operators are not implemented is that they are not needed until now.
⏩ |
Surface(const std::vector<Point*> &pnt_vec); | ||
virtual ~Surface (); | ||
explicit Surface(const std::vector<Point*>& pnt_vec); | ||
explicit Surface(Surface const& src); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to set explicit for a copy constructor ✅
👍 |
@TomFischer The |
I.e., delete move constr., assignment and move assignment operator.
4637749
to
df4def9
Compare
OpenGeoSys development has been moved to GitLab. |