[GL] Impl. of copy constructor of Surface and minor improvements #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomFischer
commented
Jun 3, 2016
TomFischer
commented
- Impl. of Surface copy construtor
- Cleanup unused code
- Clang format
- Make classes Triangle and Surface final
- Readability improvements
| /// return a geometry type | ||
| virtual GEOTYPE getGeoType() const {return GEOTYPE::SURFACE;} | ||
| Surface(Surface && src) = delete; | ||
| Surface& operator=(Surface const& src) = delete; |
There was a problem hiding this comment.
Are there reasons not to implement the copy assignment? If not I'd suggest to implement it too along with the copy ctor.
There was a problem hiding this comment.
I implemented the copy constructor since @rinkk needs it. The only reason the move constructor and the assignment and assignment move operators are not implemented is that they are not needed until now.
|
⏩ |
| Surface(const std::vector<Point*> &pnt_vec); | ||
| virtual ~Surface (); | ||
| explicit Surface(const std::vector<Point*>& pnt_vec); | ||
| explicit Surface(Surface const& src); |
There was a problem hiding this comment.
no need to set explicit for a copy constructor ✅
|
👍 |
|
@TomFischer The |
I.e., delete move constr., assignment and move assignment operator.
TomFischer
force-pushed
the
GeoLibImprovements
branch
from
4637749
to
df4def9
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.