Replace std::abort() with std::runtime_error

[norihiro-w]

as issued in #1165. I added ERRMSG macro (see 74bd882) in StringTools.h so that one can write as

throw std::runtime_error(ERRMSG("Some error with type %d", -1));

which generates an error message "Some error with type -1 at (file name), line (line no)".

[chleh]

Wouldn't it be better to introduce a macro OGS_ERROR(...) or OGS_FATAL(...) instead of always having to write throw std::runtime_error(ERRMSG(...))?

[chleh]

Error messages of more than 256 characters are pretty long, but I think there should be a check if the buffer was long enough, and if not a bigger buffer should be allocated dynamically (cf. "Notes" in http://en.cppreference.com/w/cpp/io/c/fprintf). ✅

[norihiro-w]

will check it

[chleh]

Will the error message of the exception always be printed? (I.e., in debug and release builds?)
Or do we need a dedicated try/catch block in the main function for that?

[chleh]

After the questions are answered 👍

[norihiro-w]

• Having OGS_ERROR macro is also fine, though explicitly writing std::runtime_error makes it clear what is really happening. I would like to hear how others think about it.
• I will add a try/catch block in the main function. IMO those error messages should be printed also in release mode.

[endJunction]

At first I agreed with Christoph having a single macro like OGS_FATAL. This could be also replaced with something different than throw. On the other hand there are more exception types than the runtime error; having a single macro takes the opportunity to have different error handling...

[chleh]

But catching exceptions occasionally is discouraged, AFAIK...

[norihiro-w]

how about a macro OGS_RUNTIME_ERROR? In the future, someone could add OGS_LOGICAL_ERROR or something else.

[chleh]

OGS_RUNTIME_ERROR is OK.
But is there the chance that anyone of us will ever make a distinction between different kinds of exceptions thrown?

[norihiro-w]

no idea yet

[norihiro-w]

or shall we use OGS_FATAL now and rename it later if someone wants to use different exceptions?

[norihiro-w]

updated. please check each commit

[chleh]

perfect. 👍

[ogsbot]

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.