-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding/changing names of stations #1273
Conversation
Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/2011/ |
void StationTreeModel::setNameForItem(const std::string &stn_vec_name, std::size_t id, std::string item_name) | ||
{ | ||
auto const stn_list = find_if(_lists.begin(), _lists.end(), [&stn_vec_name](ModelTreeItem* item) | ||
{ return (stn_vec_name.compare( item->data(0).toString().toStdString() ) == 0); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: You can compare for equality using ==.
after questions answered 👍 |
Looks OK. Const correctness can be improved. |
c3f39da
to
c4034e7
Compare
Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/2019/ |
7c9b316
to
e622007
Compare
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2187/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/411/ |
OpenGeoSys development has been moved to GitLab. |
...as requested for the GW tutorial book.