Removing circular dependency with XmlLutReader #1302
Conversation
| int setColorLookupTable(const std::string &filename) | ||
| { return GeoLib::readColorLookupTable(_colorLookupTable, filename); } | ||
| // int setColorLookupTable(const std::string &filename) | ||
| // { return GeoLib::readColorLookupTable(_colorLookupTable, filename); } |
There was a problem hiding this comment.
Is it possible to remove from 44-46?
There was a problem hiding this comment.
I'd rather keep this for now as this is another part of the DE where lookup-tables are used but it would need a complete rewrite. I don't want to make this PR larger than it already is.
|
Apart from small questions: 👍 |
| #include <QFileDialog> | ||
| #include <QSettings> | ||
|
|
||
| #include "Applications/DataHolderLib/Color.h" | ||
| #include "DetailWindow.h" |
|
Changes in this PR are lots compared to just moving XmlLutReader to somewhere under DE (#1284). What is a reason you have to keep it in FileIO? XmlLutReader is used only in DE, isn't it? |
One reason is to keep IO functionality local. Another is that it is now possible to use it in other utils without introducing new circular dependencies. External tools like Gocad store specifc color tables which could be reused by paraview or DE. |
|
Thanks for the two points. However
|
|
|
I don't agree with the first point (because they are not local from a viewpoint of modularity), but the second point gives some reason to keep it in FileIO. thanks |
…vtk and removed circular dependency
|
OpenGeoSys development has been moved to GitLab. |
Moves Color to DataHolderLib, introduces a new data holder for lookup-tables and removes the circular dependency.