-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AddTest #1325
Fix AddTest #1325
Conversation
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2388/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/612/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2394/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/618/ |
I had to update the PETSc ctest reference solutions since the mesh partitioning changed in @wenqing's partitioning PR. The absolute differences between the old and the new reference solutions are on the order of 1.e-9. |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/649/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2425/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/650/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2426/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/652/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2428/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/653/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2429/ |
@@ -171,12 +183,12 @@ if(NOT OGS_USE_MPI) | |||
EXECUTABLE_ARGS tes-1D-zeolite-discharge-large.prj | |||
WRAPPER time | |||
TESTER vtkdiff | |||
ABSTOL 1e-16 RELTOL 1e-16 | |||
ABSTOL 1e-3 RELTOL 1e-4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this tolerance is a liitle to sloppy...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix it as soon as I can strictly assess the correctness of the TES process, i.e., as soon as the surface extraction & output is ready.
OpenGeoSys development has been moved to GitLab. |
In #1239 I messed up the vtkdiff tests: One filename and two fieldnames are given, e.g.,
tes_zeolite_discharge_small_pcs_0_ts_19_t_0.100000.vtu pressure pressure
.If the two field names are equal, that field is compared to itself yielding zero error norms.
This PR fixes that.
TODO: Parallel PETSc tests.