Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddTest #1325

Merged
merged 4 commits into from
Aug 1, 2016
Merged

Fix AddTest #1325

merged 4 commits into from
Aug 1, 2016

Conversation

chleh
Copy link
Collaborator

@chleh chleh commented Jul 20, 2016

In #1239 I messed up the vtkdiff tests: One filename and two fieldnames are given, e.g.,
tes_zeolite_discharge_small_pcs_0_ts_19_t_0.100000.vtu pressure pressure.
If the two field names are equal, that field is compared to itself yielding zero error norms.

This PR fixes that.

TODO: Parallel PETSc tests.

@ogsbot
Copy link
Member

ogsbot commented Jul 20, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2388/

@ogsbot
Copy link
Member

ogsbot commented Jul 20, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/612/

@ogsbot
Copy link
Member

ogsbot commented Jul 23, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2394/

@ogsbot
Copy link
Member

ogsbot commented Jul 23, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/618/

@chleh
Copy link
Collaborator Author

chleh commented Jul 27, 2016

I had to update the PETSc ctest reference solutions since the mesh partitioning changed in @wenqing's partitioning PR. The absolute differences between the old and the new reference solutions are on the order of 1.e-9.

@ogsbot
Copy link
Member

ogsbot commented Jul 27, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/649/

@ogsbot
Copy link
Member

ogsbot commented Jul 27, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2425/

@ogsbot
Copy link
Member

ogsbot commented Jul 27, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/650/

@ogsbot
Copy link
Member

ogsbot commented Jul 27, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2426/

@ogsbot
Copy link
Member

ogsbot commented Jul 27, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/652/

@ogsbot
Copy link
Member

ogsbot commented Jul 27, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2428/

@ogsbot
Copy link
Member

ogsbot commented Jul 28, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/653/

@ogsbot
Copy link
Member

ogsbot commented Jul 28, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2429/

@@ -171,12 +183,12 @@ if(NOT OGS_USE_MPI)
EXECUTABLE_ARGS tes-1D-zeolite-discharge-large.prj
WRAPPER time
TESTER vtkdiff
ABSTOL 1e-16 RELTOL 1e-16
ABSTOL 1e-3 RELTOL 1e-4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this tolerance is a liitle to sloppy...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it as soon as I can strictly assess the correctness of the TES process, i.e., as soon as the surface extraction & output is ready.

@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants