Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanics Process #1340

Merged
merged 7 commits into from
Sep 7, 2016
Merged

Mechanics Process #1340

merged 7 commits into from
Sep 7, 2016

Conversation

endJunction
Copy link
Member

@endJunction endJunction commented Aug 8, 2016

... including linear and Burger's materials.

Todo:

  • Resolve circular deps SolidModels <-> ProcessLib; There is header file dependency because in SolidModels the ProcessLib::Parameters are requiered and the SolidModels are required by the Process itself. There are several ideas how to resolve this type of issues. To be discussed ASAP.
  • Documentation of benchmarks
  • Code documentation, especially:
    • Interface of the SolidsBase
  • Update Traction and Displacement BCs (use Neumann and Dirichlet instead)
  • Fix compilation issues.
  • MathLib unit tests.
  • Resolve Eigen/MSVC compilation issue.

@chleh
Copy link
Collaborator

chleh commented Aug 8, 2016

4k lines of changes. Can't you split that into smaller pieces? 😄

@endJunction
Copy link
Member Author

endJunction commented Aug 8, 2016

@chleh Down to 3k and will be less with new bcs 2.8k 2.3k 1.5k 1.4k I might be splitting the MathLib/KelvinVector things while preparing this to its final glance.

@endJunction
Copy link
Member Author

endJunction commented Aug 10, 2016

FYI
There is a problem with the combination of VisualStudio12 2013 ( compiler identification is MSVC 18.0.31101.0) and Eigen-3.2.5 resulting in compilation error:
...

The error was, as it is common, between the chair and the keyboard...

#ifndef MATERIALLIB_SOLIDMODELS_CREATELINEARELASTICISOTROPIC_H_
#define MATERIALLIB_SOLIDMODELS_CREATELINEARELASTICISOTROPIC_H_

#include "ProcessLib/Utils/ProcessUtils.h" // required for findParameter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the circular dependency still exists here.

@norihiro-w
Copy link
Collaborator

👍 from my side

@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants