Create OGS-5 direct Neumann boundary conditions (in OGS-5: source terms) #1346
Conversation
|
Only curious: What means "gwn" in node_aggregated_gwn? |
| "boundary condition", | ||
| true, | ||
| "", | ||
| "filename for mesh input"); |
There was a problem hiding this comment.
Should it maybe be stressed, that the mesh is the surface mesh?
|
My comments basically address documentation. Afterwards 👍 |
TomFischer
force-pushed
the
createNeumannTool
branch
from
81176cc
to
4a438a6
Compare
|
👍 |
| /// to cells | ||
| /// @param prop_name name of the cell based property within the \c mesh | ||
| /// @return vector of integration value associated to the surface mesh nodes | ||
| static std::vector<double> getSurfaceIntegratedValueForNodes( |
There was a problem hiding this comment.
I suggest moving these integration functions to somewhere else. The functions are nothing to do with surface extraction.
There was a problem hiding this comment.
@norihiro-w You are right. I'm unsure where the correct place is. Should it go to NumLib/Fem/Integration or do you have a better suggestion?
There was a problem hiding this comment.
I'm also unsure. it could be placed under
- MeshLib/MeshEditing or new dir Utils (?)
- new dir NumLib/Integration
- ProcessLib/Utils
NumLib/Fem/Integration isn't a good place for this because it focuses on element-level integration.
There was a problem hiding this comment.
Or move the code into the cmdline tool until we have a second use for it?
There was a problem hiding this comment.
MeshLib/MeshEditing or MeshLib/Utils or into the cmdline tool sounds good.
There was a problem hiding this comment.
It does not fit into MeshEditing since the mesh is not edited. So I moved the piece of code to the command line tool.
|
⏩ after suggested changes... |
TomFischer
force-pushed
the
createNeumannTool
branch
from
35381f6
to
25d0c87
Compare
TomFischer
force-pushed
the
createNeumannTool
branch
from
25d0c87
to
311fb03
Compare
|
OpenGeoSys development has been moved to GitLab. |
createNeumannBc --result-out <output file name> --property-name <string (property name)> --in-mesh <filename for mesh input>The tool integrates the given element property (given via switch
property-name) and writes the computed data as aPropertyVectorwith the name node_aggregated_gwn into the mesh. The tool also outputs an OGS-5 direct source term (Neumann boundary condition) data file, i.e., first column is the id of the mesh node and second column contains the integrated value.