Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmit raster data to element properties #1347

Merged
merged 24 commits into from
Aug 17, 2016

Conversation

TomFischer
Copy link
Member

@TomFischer TomFischer commented Aug 11, 2016

Rework of tool to transmit raster data to a mesh.

@@ -213,6 +213,8 @@ class Element

}; /* class */

bool isPointInElementXY(MathLib::Point3d const& p, Element const& e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs docu and a todo for other than triangle element types.

@chleh
Copy link
Collaborator

chleh commented Aug 12, 2016

Generally OK after questions. 👍
But I think the unit-related code shouldn't be in a general tool. (Or it should be renamed to something with precipitation).

@TomFischer
Copy link
Member Author

Thanks @chleh and @endJunction for the valuable review. I set the status to WIP to rework the code.

@TomFischer TomFischer force-pushed the TransmitElementPropertiesII branch 2 times, most recently from 20c0be5 to f4221a1 Compare August 15, 2016 08:03
@@ -164,6 +164,10 @@ class Mesh : BaseLib::Counter<Mesh>
Properties _properties;
}; /* class */

void scaleMeshPropertyVector(MeshLib::Mesh& mesh,
Copy link
Member

@endJunction endJunction Aug 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// Scales the mesh property with name \c property_name by given \c factor.
/// \note The property must be a "double" property.

@TomFischer TomFischer merged commit 735e35f into ufz:master Aug 17, 2016
@TomFischer TomFischer deleted the TransmitElementPropertiesII branch August 17, 2016 03:51
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants