-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerical Jacobian assembly #1352
Conversation
87d6c0a
to
e1b39cb
Compare
For our upcoming discussion. Some highlighted changes:
|
2173311
to
4e58e8a
Compare
For the corresponding ctest prj files see ufz/ogs-data#22 |
@norihiro-w suggested to use Eigen::Block instead of the mapping std::vector→Eigen::Map. I'd rather keep my proposed solution, because I think that the Eigen::Block solution will not result in less code to be written by the user. |
Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/2617/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/897/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2674/ |
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/898/ |
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2675/ |
#ifndef MATHLIB_EIGENMAPTOOLS_H | ||
#define MATHLIB_EIGENMAPTOOLS_H | ||
|
||
#include <Eigen/Core> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std header should be included first ✅ :
looks good |
@norihiro-w on truesday you pointed to possible issues regarding matrix data alignment. Shall they be addressed in this PR or later on? |
195141c
to
398cac6
Compare
Travis says: |
OpenGeoSys development has been moved to GitLab. |
Closes #1338.
Follow-up of #1367.
Maybe this PR needs some discussion...
Some features:
assemble(M, K, b)
andassembleJacobian(J)
, now there areassemble(M, K, b)
andassembleWithJacobian(M, K, b, J)
Todo (after basic discussions are settled):
#pragma once