Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerical Jacobian assembly #1352

Merged
merged 30 commits into from
Sep 20, 2016
Merged

Numerical Jacobian assembly #1352

merged 30 commits into from
Sep 20, 2016

Conversation

chleh
Copy link
Collaborator

@chleh chleh commented Aug 15, 2016 •
edited
Loading

Closes #1338.
Follow-up of #1367.
Maybe this PR needs some discussion...

Some features:

  • Basically the global MatrixVectorAssembler now is back again. I obviously removed it too early.
  • The individual local assemblers do not own local matrices and vectors anymore.
  • Changed the assembly slightly. Before there were the methods assemble(M, K, b) and assembleJacobian(J), now there are assemble(M, K, b) and assembleWithJacobian(M, K, b, J)

Todo (after basic discussions are settled):

  • docu
  • replace #pragma once
  • mark TES Newton test as large

@chleh chleh force-pushed the newton-raphson branch 4 times, most recently from 87d6c0a to e1b39cb Compare August 22, 2016 07:57
@chleh
Copy link
Collaborator Author

chleh commented Aug 23, 2016

For our upcoming discussion. Some highlighted changes:

@chleh chleh force-pushed the newton-raphson branch 2 times, most recently from 2173311 to 4e58e8a Compare August 24, 2016 08:35
@chleh
Copy link
Collaborator Author

chleh commented Aug 24, 2016

For the corresponding ctest prj files see ufz/ogs-data#22

@chleh
Copy link
Collaborator Author

chleh commented Aug 24, 2016

@norihiro-w suggested to use Eigen::Block instead of the mapping std::vector→Eigen::Map. I'd rather keep my proposed solution, because I think that the Eigen::Block solution will not result in less code to be written by the user.

@ogsbot
Copy link
Member

ogsbot commented Aug 24, 2016

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/2617/

@ogsbot
Copy link
Member

ogsbot commented Aug 24, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/897/

@ogsbot
Copy link
Member

ogsbot commented Aug 24, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2674/

@ogsbot
Copy link
Member

ogsbot commented Aug 24, 2016

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/898/

@ogsbot
Copy link
Member

ogsbot commented Aug 24, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2675/

norihiro-w
norihiro-w reviewed Aug 24, 2016
View reviewed changes
MathLib/LinAlg/Eigen/EigenMapTools.h
#ifndef MATHLIB_EIGENMAPTOOLS_H
#define MATHLIB_EIGENMAPTOOLS_H

#include <Eigen/Core>
Copy link
Collaborator

@norihiro-w norihiro-w Aug 24, 2016 •
edited by chleh
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std header should be included first ✅ :

@norihiro-w
Copy link
Collaborator

looks good

@chleh
Copy link
Collaborator Author

chleh commented Aug 25, 2016

@norihiro-w on truesday you pointed to possible issues regarding matrix data alignment. Shall they be addressed in this PR or later on?

chleh and others added 22 commits September 20, 2016 10:07
@chleh
[NL] interface changes
469267f
@chleh
[T] adapted to time integration interface changes
527a7da
@chleh
[T] added Jacobian assembler tests
caa581c
@chleh
[App] added Newton-Raphson ctests
e0db088
@chleh
[T] fixed tests for PETSc
e9efbc5
@chleh
fixed compilation errors
cf469b5
@chleh
[MaL] templated EigenMapTools
feb6b82
@chleh
[PL] adapted to changed EigenMapTools
1eb5719
@chleh
[T] adapted to changed EigenMapTools
557a341
@chleh
[PL] use EigenMapTools in local assemblers.
ade940f
@chleh
[PL] added Jacobian assembler docu
a3ba818
@chleh
[PL] documented VectorMatrixAssembler
e5e6d5d
@chleh
renamed toZeroedMatrix -> createZeroedMatrix
8d0437b
@chleh
[NL] improved documentation
7ade23e
@chleh
[PL] improved error message
dfc4437
@endJunction @chleh
fixup App/ProjectData
063d004
@endJunction @chleh
fixup GWF
5d482e0
@endJunction @chleh
fixup HeatConduction
358a355
@endJunction @chleh
fixup SD
d9cd80d
@endJunction @chleh
fixup TES
2446e04
@chleh
[PL] fix compilation errors
ec2f050
@chleh
[Data] added Newton ctests
398cac6
@chleh
Copy link
Collaborator Author

chleh commented Sep 20, 2016

Travis says: [ FAILED ] MaterialLibSolidsKelvinVector6.Inverse. Going to merge this now

@chleh chleh merged commit 4af2b8a into ufz:master Sep 20, 2016
@chleh chleh deleted the newton-raphson branch September 20, 2016 10:27
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numerical Jacobian
6 participants
@chleh @ogsbot @norihiro-w @endJunction @TomFischer @wenqing