Based Neumann/Robin BCs and ICs on the Parameter class. #1356
Conversation
|
Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/2419/ |
|
Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/2434/ |
|
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2570/ |
|
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/793/ |
| } | ||
| else | ||
| { | ||
| OGS_FATAL("Cannot construct property of given type \'%s\'.", |
There was a problem hiding this comment.
Sould it be parameter instead of property? ✅
There was a problem hiding this comment.
Indeed. I'll correct it in #1357.
|
@TomFischer thanks for your comments. Please keep in mind that this PR is a follow-up of #1357. |
|
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/867/ |
|
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2644/ |
chleh
force-pushed
the
param-interface
branch
3 times, most recently
from
f824777
to
32aef77
Compare
| auto const param_name = config.getConfigParameter<std::string>("parameter"); | ||
| DBUG("Using parameter %s", param_name.c_str()); | ||
|
|
||
| auto& param = findParameter<double>(param_name, parameters, 1); |
|
After questions answered 👍 |
|
Independent of discussion points I touched ⏩ |
|
I slightly reduced load on Jenkins, but it takes some time to handle all the updates of the PRs'. We have only one docker client running, and that one is not particularly fast. |
|
OpenGeoSys development has been moved to GitLab. |
This PR is for the whole picture. I'll split off a PR for only the parameter class.
See also ufz/ogs-data#18.
Follow-up of #1357.