-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time dependent Dirichlet and Neumann BCs #1380
Conversation
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2748/ |
f554024
to
cd3b527
Compare
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2764/ |
cd3b527
to
288578f
Compare
initializeDirichletBCs(_boundary_conditions, _dirichlet_bcs); | ||
// for each BC there will be storage for Dirichlet BC, which by default is | ||
// empty and has to be filled by the respective BC object if needed. | ||
_dirichlet_bcs.resize(_boundary_conditions.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I misunderstand the comment, but resize sets the _dirichlet_bcs size, so !_dirichlet_bcs.empty()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each BC can be Dirichlet (or "essential") or natural, or in the future maybe even both, so each of the BCs need some storage for it. As you wrote, this implies that _dirichlet_bcs
is not empty. However, the memory overhead for that should be rather small, because only some empty std::vector
s are created.
d24ebd7
to
6e696b7
Compare
I've rebase it and included the mechanics and the thermal conductivity processes. |
61df58e
to
1320173
Compare
👍 |
// convert mesh node ids to global index for the given component | ||
bc_values.ids.reserve(bc_values.ids.size() + _mesh_node_ids.size()); | ||
bc_values.values.reserve(bc_values.values.size() + _mesh_node_ids.size()); | ||
for (auto id : _mesh_node_ids) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const auto id
?
1320173
to
1fec357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing new PR review feature of github.
Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/2824/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting feature.
1fec357
to
ab7dd7b
Compare
ab7dd7b
to
3382ffe
Compare
The original preTimestep is calling boundary conditions' preTimestep now.
OpenGeoSys development has been moved to GitLab. |
Time dependence is implemented using curves, i.e.
f(t, x) := c(t) * p(x)
, wherec
is a curve andp
is a parameter.The Parameter interface has been extended s.t. parameters now can tell if they are time dependent.