Supporting heterogeneously distributed DoF #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i will rework on this after #1437 |
norihiro-w
force-pushed
the
doftable-hetero-e
branch
2 times, most recently
from
5a0f186
to
90afcec
Compare
norihiro-w
force-pushed
the
doftable-hetero-e
branch
2 times, most recently
from
19b23bd
to
ec22a16
Compare
endJunction
approved these changes
Oct 4, 2016
There was a problem hiding this comment.
Reviewed together with Christoph: Looks good!
One question remained still (and might be for later refactoring): Would it be possible to use the elements of the MeshSubset, instead of adding a new argument (active elements)? I think the active elements behaviour was also design feature when the MeshSubsets were implemented.
|
The elements of MeshSubset mean they are included in DoF. If active elements, which are not Dof but used for local assembly, are to be included there, we need to add another variables and functions. |
|
Please rebase to 6.0.7 before merging. |
norihiro-w
force-pushed
the
doftable-hetero-e
branch
from
ec22a16
to
18e2e8d
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of #1433
Untill now,
LocalToGlobalIndexMapassumes every DoF is distributed over all mesh elements, and creates_rowsobject storing all the DoF data for every elements. However in my application, some DoF are defined only on lower-dimension mesh element nodes (e.g. lines in 2D case), and_rowsobject stores unnecessary empty DoF data for some elements. This PR tries to avoid creating the unnecessary DoF data with the following changesfindGlobalIndices()(findGlobalIndicesWithElementID()), which creates_rowsobject from an element ID. The original version assumes the ID is equal to an index in a given vector, which is probably necessary for creating boundary conditions.