Solve Axially Symmetric Problems #1443

chleh · 2016-09-26T13:25:06Z

Closes #1310.

The coordinates are mapped as follows:
Cartesian x to cylindrical r, Cartesian y to cylindrical z, i.e., axial symmetry is about the Cartesian y axis.

The solution in this PR is rather ad-hoc, so maybe some discussions are needed.

Major changes:

Mesh now has flag is_axially_symmetric
Constructors of all processes and local assemblers now have an argument telling if the problem is axially symmetric.
The ShapeMatrices structure is extended by an integralMeasure member, which is 1 in the Cartesian case and 2 * pi * r in the axial case.

The added test results for GWFlow, T and TES are compared to numerical data from a wedge-shaped domain. I've added the corresponding wedge-files to the data repo and commented test cases Tests.cmake.

wenqing

Introducing integralMeasure is a nice way to handle the axisymmetry.

wenqing · 2016-09-27T15:09:09Z

NumLib/Fem/CoordinatesMapping/ShapeMatrices-impl.h

@@ -64,6 +64,7 @@ inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFie
    setZero(shape, ShapeDataFieldType<ShapeMatrixType::DNDR>());
    setMatrixZero(shape.J);
    shape.detJ = .0;
+    shape.integralMeasure = 0.0;


Why not 1.0?

Because it's the setZero() function.

wenqing · 2016-09-27T15:11:47Z

MeshLib/Mesh.h

@@ -125,6 +125,16 @@ class Mesh : BaseLib::Counter<Mesh>
    MeshLib::Properties & getProperties() { return _properties; }
    MeshLib::Properties const& getProperties() const { return _properties; }

+    bool isAxiallySymmetric() const { return _is_axially_symmetric; }
+    void setAxiallySymmetric(bool is_axial_symmetric) {


It could also to 1D mesh (excluding that for the deformation problem)

I excluded it, because no interesting 1D axially symmetric problem came to my mind. Do you want 1D, too?

It may be needed for some benchmarking, and it can be considered in future if it is really needed.

Then I'd like to postpone the 1D case.

wenqing · 2016-09-27T15:12:08Z

NumLib/Fem/FiniteElement/TemplateIsoparametric.h

+            rs[i] = (*nodes[i])[0];
+        }
+        auto const r = N.dot(rs);
+        return r;


need

if (r == 0.) r = 0.5/pi

for line integration at r = 0, which is used to apply a distributed source term along the axis.

In addition the case of integration point at edges (only exist in triangle) must be avoid, which are secured with the present integration point definitions in GaussLegendreTri.cpp.

I don't fully understand your comment. Let's discuss tomorrow.

For the general case of Neumann BC, 2 pi* int q(l) r \phi dl is the integration formulas. However, if the Neumann BC is applied to the axis, where r = 0, the correct formulas is
int q(z) \phi dz. To avoid changing Neumann BC integration function, I suggested to added this if-condition.

Maybe the good place to check that is in the Neumann BC calculation.

Resolved in discussion.
I leave the NeumannBC as it is.
Regarding the zero radius for integration points on edges I'll add a comment in computeIntegralMeasure().

wenqing · 2016-09-27T15:12:13Z

NumLib/Fem/FiniteElement/TemplateIsoparametric.h

+
+        auto const r = interpolateZerothCoordinate(shape.N);
+        shape.integralMeasure =
+            2.0 * 3.14159265358979323846264338327950288419 * r;


use boost constant of pi like Nori used in his PR, or set it somewhere as a global constant? ✅

wenqing

👍

wenqing · 2016-09-29T14:55:10Z

NumLib/Fem/FiniteElement/TemplateIsoparametric.h

@@ -133,6 +133,9 @@ class TemplateIsoparametric
            return;
        }

+        // Note: If an integration point is located at the rotation axis, r will
+        // be zero which might lead to problems with the assembled equation
+        // system.


If an integration point is located at the rotation axis, r will be zero-->

For triangle element, if an integration point is located at edge of the unit triangle, r is possible to be zero

Added your comment for further clarification.

endJunction · 2016-09-29T15:58:32Z

Applications/CLI/Tests.cmake

+        TESTER vtkdiff
+        #ABSTOL 1.6e-3 RELTOL 1e-3
+        #DIFF_DATA
+        #wedge-1e2-ang-0.2-surface.vtu square_1e2_axi_pcs_0_ts_1_t_1.000000.vtu temperature temperature


Why the comments?

Insufficient cleanup...

endJunction · 2016-09-29T16:00:53Z

Applications/CLI/Tests.cmake

+         EXECUTABLE_ARGS square_1e2_axi.prj
+         WRAPPER time
+         TESTER vtkdiff
+         ABSTOL 1.7e-5 RELTOL 1e-5


TBD: Why are the results so different?

The reference results are from a simulation on a wedge-shaped domain having a wedge angle of 0.02 (rad). I assume that the difference is mostly caused by the size of the angle: Larger angle results in larger deviations.

endJunction · 2016-09-29T16:10:54Z

ProcessLib/SmallDeformation/CreateLocalAssemblers.h

@@ -30,7 +30,6 @@ template <unsigned GlobalDim, int DisplacementDim,
 void createLocalAssemblers(
    NumLib::LocalToGlobalIndexMap const& dof_table,
    std::vector<MeshLib::Element*> const& mesh_elements,
-    unsigned const integration_order,


The integration_order is removed because it's not used in createlocalassemblers, but it is still in the concrete local assemblers, isn't it?

The integration order is now contained in extra_ctor_args. That way one does not need to declare additional arguments in utility code, like createLocalAssemblers(), anymore.

endJunction · 2016-09-29T16:28:25Z

In ogs-data there are some strange files with '.msh' extension ;)
Can we have vtu please!

chleh · 2016-09-30T07:07:55Z

Actually I'm a bit too lazy to convert the .msh files and erase them from the git history only for the reason of style...

endJunction · 2016-09-30T10:16:03Z

I checked with the updated tests' input (msh->vtu) and ctest -R axi has 100% passed.

ogsbot · 2016-09-30T12:55:52Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/1297/

ogsbot · 2016-09-30T13:53:16Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/1298/

endJunction · 2016-10-03T21:16:27Z

Also don't forget the changelog (depending on the version of the ufz/master)

ogsbot · 2020-06-19T12:35:24Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

chleh added the WIP 🏗️ label Sep 26, 2016

chleh force-pushed the axial-symmetry branch 2 times, most recently from 90fa9bf to 7f120ed Compare September 27, 2016 08:27

chleh added please review and removed WIP 🏗️ labels Sep 27, 2016

wenqing reviewed Sep 27, 2016

View reviewed changes

wenqing approved these changes Sep 29, 2016

View reviewed changes

wenqing reviewed Sep 29, 2016

View reviewed changes

endJunction approved these changes Sep 29, 2016

View reviewed changes

endJunction added please rebase and removed please review labels Sep 30, 2016

chleh force-pushed the axial-symmetry branch from 76a0ad5 to 7b0499e Compare September 30, 2016 12:49

chleh force-pushed the axial-symmetry branch from c8146a9 to b371626 Compare September 30, 2016 14:58

chleh added 11 commits October 4, 2016 08:39

[AppL] added axially symm config

fc396b7

[MeL] mesh can be axially symmetric

bfc13f6

[PL] started axial symmetry

09a467f

[PL] utils forward axial symmetry

0c9e5d9

[T] adapted to changes

58f8f25

[NL] added integral measure to shapematrices

6550018

[T] need to know if axially symmetric

e865c83

[NL] start computing integral measure

c13a629

[PL] tell shapematrices about axial symmetry

9897f10

[NL] added integral measure formula

2ff5a74

[PL] TES: pass all shape matrices

fcd2867

chleh added 14 commits October 4, 2016 08:39

[PL] add integral measure term to natural BCs

00ca85a

[PL] add integral measure term to processes (except SmallDef)

a2d6ab1

[PL] enable axisymmetric BC creation

631329c

[PL] SmallDef use integral measure

dc0d401

[PL] SmallDef pass axial symmetry info

d43af84

[PL] axial symmetric BMatrix

2773c8f

[PL] forward call for radius computation

f190d25

[PL] SmallDef init axisymmetric BMatrices

c3f93fb

[PL] SmallDef additionall secondary output

adbf120

[App] Added axisymmetric tests

bb8f867

[Data] added axisymmetric tests

88d9f14

[PL] made flux computation axial symmetry ready

4b78a6f

[PL] fixed compiler warnings

23af8a5

updated changelog

9b74c60

chleh force-pushed the axial-symmetry branch from b371626 to 9b74c60 Compare October 4, 2016 06:43

chleh merged commit bcde12c into ufz:master Oct 4, 2016

chleh removed the please rebase label Oct 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solve Axially Symmetric Problems #1443

Solve Axially Symmetric Problems #1443

chleh commented Sep 26, 2016 •

edited

Loading

wenqing left a comment

wenqing Sep 27, 2016

chleh Sep 27, 2016

wenqing Sep 27, 2016

chleh Sep 27, 2016

wenqing Sep 27, 2016

chleh Sep 27, 2016

wenqing Sep 27, 2016

chleh Sep 27, 2016

wenqing Sep 27, 2016

wenqing Sep 28, 2016

chleh Sep 29, 2016

wenqing Sep 27, 2016 •

edited by chleh

Loading

wenqing left a comment

wenqing Sep 29, 2016

chleh Sep 30, 2016

endJunction Sep 29, 2016

chleh Sep 30, 2016

endJunction Sep 29, 2016

chleh Sep 30, 2016

endJunction Sep 29, 2016

chleh Sep 30, 2016

endJunction commented Sep 29, 2016

chleh commented Sep 30, 2016 •

edited

Loading

endJunction commented Sep 30, 2016

ogsbot commented Sep 30, 2016

ogsbot commented Sep 30, 2016

endJunction commented Oct 3, 2016

ogsbot commented Jun 19, 2020

Solve Axially Symmetric Problems #1443

Solve Axially Symmetric Problems #1443

Conversation

chleh commented Sep 26, 2016 • edited Loading

wenqing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wenqing Sep 27, 2016 • edited by chleh Loading

Choose a reason for hiding this comment

wenqing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction commented Sep 29, 2016

chleh commented Sep 30, 2016 • edited Loading

endJunction commented Sep 30, 2016

ogsbot commented Sep 30, 2016

ogsbot commented Sep 30, 2016

endJunction commented Oct 3, 2016

ogsbot commented Jun 19, 2020

chleh commented Sep 26, 2016 •

edited

Loading

wenqing Sep 27, 2016 •

edited by chleh

Loading

chleh commented Sep 30, 2016 •

edited

Loading