-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration order in project files. #1464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the integration order is still hard-coded in the flux process. What about that?
@@ -266,6 +266,10 @@ void ProjectData::parseProcesses(BaseLib::ConfigTree const& processes_config, | |||
//! \ogs_file_param{process__type} | |||
auto const name = process_config.getConfigParameter<std::string>("name"); | |||
|
|||
//! \ogs_file_param{process__integration_order} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has to be in the line before getConfigParameter
. I.e., please move it down one line. ✅
Updated the surface flux too; the integration order is same as in the caller process (GWF in this case). |
👍 |
1 similar comment
👍 |
Please rebase to 6.0.7 before merging. |
b4aad6e
to
dca8a27
Compare
Jenkins, test this please! |
dca8a27
to
ad73241
Compare
Remove default value.
Also fix the order in the initializer list.
ad73241
to
c86740b
Compare
@endJunction In the data repository, branch IntegrationOrder is not merged to master. |
@wenqing Yes, thanks forgot to update the Tests/Data. |
OpenGeoSys development has been moved to GitLab. |
Until now the integration order was hardcoded into default value of 2 in Process class.
I introduced a new tag
<integration_order>
for each<process>
which is parsed and propagated to theProcess
ctor.