Integration order in project files. #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chleh
approved these changes
Oct 5, 2016
| @@ -266,6 +266,10 @@ void ProjectData::parseProcesses(BaseLib::ConfigTree const& processes_config, | |||
| //! \ogs_file_param{process__type} | |||
| auto const name = process_config.getConfigParameter<std::string>("name"); | |||
|
|
|||
| //! \ogs_file_param{process__integration_order} | |||
There was a problem hiding this comment.
This comment has to be in the line before getConfigParameter. I.e., please move it down one line. ✅
|
Updated the surface flux too; the integration order is same as in the caller process (GWF in this case). |
|
👍 |
1 similar comment
|
👍 |
|
Please rebase to 6.0.7 before merging. |
endJunction
force-pushed
the
IntegrationOrderInput
branch
3 times, most recently
from
b4aad6e
to
dca8a27
Compare
|
Jenkins, test this please! |
endJunction
force-pushed
the
IntegrationOrderInput
branch
from
dca8a27
to
ad73241
Compare
Remove default value.
Also fix the order in the initializer list.
endJunction
force-pushed
the
IntegrationOrderInput
branch
from
ad73241
to
c86740b
Compare
|
@endJunction In the data repository, branch IntegrationOrder is not merged to master. |
|
@wenqing Yes, thanks forgot to update the Tests/Data. |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the integration order was hardcoded into default value of 2 in Process class.
I introduced a new tag
<integration_order>for each<process>which is parsed and propagated to theProcessctor.