[Mesh] check IDs of nonlinear nodes #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis error is |
|
👍 |
|
because I noticed mesh files in Dima's HM examples are not following the assumption. The assumption came from ogs5 and can be changed if needed. But till then, because some algorithms and the node partitioned mesh class are based on this, we need the check. |
|
Thank you for the explanation. |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
Meshclass assumes nodes are stored in the order: 1. base nodes, 2. nonlinear nodes. But the assumption has not been checked by ogs and it's possible a user provides a mesh with wrong node ordering.