New tool: createQuadraticMesh #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
approved these changes
Oct 25, 2016
| if (!mesh) | ||
| return EXIT_FAILURE; | ||
|
|
||
| INFO("Creat a quadratic order mesh"); |
| return (_id1 == r._id1 && _id2 == r._id2); | ||
| } | ||
|
|
||
| friend bool operator< (Edge const& l, Edge const& r) |
There was a problem hiding this comment.
friend is not needed here, can be defined outside of Edge. ✅
TomFischer
reviewed
Oct 26, 2016
| @@ -107,6 +107,12 @@ class Properties | |||
| std::vector<std::size_t> const& exclude_elem_ids, | |||
| std::vector<std::size_t> const& exclude_node_ids) const; | |||
|
|
|||
| /** copy all PropertyVector objects stored in the (internal) map but | |||
| * PropertyVectoronly objects with the given MeshItemType are excluded. | |||
There was a problem hiding this comment.
spelling: PropertyVectoronly ✅
TomFischer
reviewed
Oct 26, 2016
| double coords[3]; | ||
| for (Edge const& edge : vec_edges) | ||
| { | ||
| auto &node0 = *vec_new_nodes[edge._id1]; |
There was a problem hiding this comment.
Why not auto const & node0? ✅
added 2 commits
October 26, 2016 07:44
norihiro-w
force-pushed
the
gen-quadratic-mesh
branch
from
2bb36c1
to
05a7f74
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CLI tool
createQuadraticMeshfor creating a quadratic order mesh based on an existing linear order mesh. At the moment, it supports only Line2 and Quad4 elements, which are converted to Line3 and Quad8. To copy MaterialIDs to the new mesh, I had to modifyMeshLib::Properties.