-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIE/HM part 5: Process implementation #1541
Conversation
be2f898
to
977ceb9
Compare
break; | ||
default: | ||
OGS_FATAL( | ||
"SMALL_DEFORMATION_WITH_LIE process does not support " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SMALL_DEFORMATION -> HYDRO_MECHANICS ✅
@@ -0,0 +1,17 @@ | |||
/** | |||
* \copyright | |||
* Copyright (c) 2012-2015, OpenGeoSys Community (http://www.opengeosys.org) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 ;) ✅
|
||
DBUG("created %d DoF", _local_to_global_index_map->size()); | ||
|
||
//std::cout << *_local_to_global_index_map.get() << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove or put into #ifndef NDEBUG
. Also the iostream
include. ✅
_vec_fracutre_matrix_elements.insert(_vec_fracutre_matrix_elements.begin(), vec_vec_fracture_matrix_elements[0].begin(), vec_vec_fracture_matrix_elements[0].end()); | ||
_vec_fracutre_nodes.insert(_vec_fracutre_nodes.begin(), vec_vec_fracture_nodes[0].begin(), vec_vec_fracture_nodes[0].end()); | ||
|
||
if (!_vec_fracutre_elements.empty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: fracture ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far I don't see any technical problems aside the few comments I made before. 👍
if (process_variables.size() > 3) | ||
OGS_FATAL("Currently only one displacement jump is supported"); | ||
|
||
// Constitutive relation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to have a class for the common parameters of HM process and a creating function for the class that can parsing such parameters. With this, the duplication of parsing HM parameters among HM related processes can be avoid, and the code is easy to be maintained. This is just a suggestion for future improvement of HydroMechanics related processes not for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it might be better to share some parts with HM process, if someone can maintain the LIE stuff. this is something you guys can discuss later because common parts in other processes should also be extracted.
# Conflicts: # Applications/ApplicationsLib/ProjectData.cpp # Conflicts: # Applications/ApplicationsLib/ProjectData.cpp
Seems the review are finished. ⏩ when CI gives green light. |
OpenGeoSys development has been moved to GitLab. |
a part of #1535, depends on #1540
This PR adds implementations of the process class and a test for a single fracture case.
TODO