LIE/HM part 5: Process implementation #1541
Conversation
norihiro-w
force-pushed
the
LIE-HM-5
branch
4 times, most recently
from
be2f898
to
977ceb9
Compare
| break; | ||
| default: | ||
| OGS_FATAL( | ||
| "SMALL_DEFORMATION_WITH_LIE process does not support " |
There was a problem hiding this comment.
SMALL_DEFORMATION -> HYDRO_MECHANICS ✅
| @@ -0,0 +1,17 @@ | |||
| /** | |||
| * \copyright | |||
| * Copyright (c) 2012-2015, OpenGeoSys Community (http://www.opengeosys.org) | |||
|
|
||
| DBUG("created %d DoF", _local_to_global_index_map->size()); | ||
|
|
||
| //std::cout << *_local_to_global_index_map.get() << std::endl; |
There was a problem hiding this comment.
Please remove or put into #ifndef NDEBUG. Also the iostream include. ✅
| _vec_fracutre_matrix_elements.insert(_vec_fracutre_matrix_elements.begin(), vec_vec_fracture_matrix_elements[0].begin(), vec_vec_fracture_matrix_elements[0].end()); | ||
| _vec_fracutre_nodes.insert(_vec_fracutre_nodes.begin(), vec_vec_fracture_nodes[0].begin(), vec_vec_fracture_nodes[0].end()); | ||
|
|
||
| if (!_vec_fracutre_elements.empty()) |
| if (process_variables.size() > 3) | ||
| OGS_FATAL("Currently only one displacement jump is supported"); | ||
|
|
||
| // Constitutive relation. |
There was a problem hiding this comment.
It might be good to have a class for the common parameters of HM process and a creating function for the class that can parsing such parameters. With this, the duplication of parsing HM parameters among HM related processes can be avoid, and the code is easy to be maintained. This is just a suggestion for future improvement of HydroMechanics related processes not for this PR.
There was a problem hiding this comment.
yes it might be better to share some parts with HM process, if someone can maintain the LIE stuff. this is something you guys can discuss later because common parts in other processes should also be extracted.
# Conflicts: # Applications/ApplicationsLib/ProjectData.cpp # Conflicts: # Applications/ApplicationsLib/ProjectData.cpp
|
Seems the review are finished. ⏩ when CI gives green light. |
|
OpenGeoSys development has been moved to GitLab. |
a part of #1535, depends on #1540
This PR adds implementations of the process class and a test for a single fracture case.
TODO