New tool: convertToLinearMesh #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
endJunction
approved these changes
Nov 18, 2016
| { | ||
| class Mesh; | ||
|
|
||
| std::unique_ptr<MeshLib::Mesh> convertToLinearMesh( |
There was a problem hiding this comment.
Minor: A short comment about the details would be nice. ✅
TomFischer
reviewed
Nov 21, 2016
| namespace MeshLib | ||
| { | ||
|
|
||
| /// Converts a non-linear mesh to a linear meash. All the mesh properties will |
TomFischer
reviewed
Nov 21, 2016
| continue; | ||
|
|
||
| auto const n_src_comp = src_prop->getNumberOfComponents(); | ||
| // convert 2D vector to 3D. Otherwise Paraview Calculator filter does not recognize |
There was a problem hiding this comment.
Maybe the converting will be valueable in other scenarios, too. Do you have plans to implement this as a separate functionality tool?
There was a problem hiding this comment.
sorry this conversion is already included in ProcessLib/LIE/Common/PostUtils.h, and shouldn't be here. I will remove it.
I don't have a plan yet. I can implement a CLI tool having this conversion. is it enough for you? I don't have a good idea about how to implement this to the process output.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new tool
convertToLinearMeshwhich will convert a nonlinear mesh to a linear mesh while keeping property values for base nodes.