-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tool: convertToLinearMesh #1554
Conversation
{ | ||
class Mesh; | ||
|
||
std::unique_ptr<MeshLib::Mesh> convertToLinearMesh( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: A short comment about the details would be nice. ✅
namespace MeshLib | ||
{ | ||
|
||
/// Converts a non-linear mesh to a linear meash. All the mesh properties will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: meash
continue; | ||
|
||
auto const n_src_comp = src_prop->getNumberOfComponents(); | ||
// convert 2D vector to 3D. Otherwise Paraview Calculator filter does not recognize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the converting will be valueable in other scenarios, too. Do you have plans to implement this as a separate functionality tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry this conversion is already included in ProcessLib/LIE/Common/PostUtils.h, and shouldn't be here. I will remove it.
I don't have a plan yet. I can implement a CLI tool having this conversion. is it enough for you? I don't have a good idea about how to implement this to the process output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok to remove it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
OpenGeoSys development has been moved to GitLab. |
This PR adds the new tool
convertToLinearMesh
which will convert a nonlinear mesh to a linear mesh while keeping property values for base nodes.