Add a model of Curve for capillary pressure saturation #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chleh
approved these changes
Nov 25, 2016
| { | ||
| public: | ||
| CapillaryPressureSaturationCurve( | ||
| std::unique_ptr<MathLib::PiecewiseLinearMonotonicCurve>& curve_data) |
There was a problem hiding this comment.
Since you move from this, please use &&. (and std::move on the caller side).
endJunction
reviewed
Nov 25, 2016
| @@ -32,6 +32,7 @@ std::unique_ptr<CapillaryPressureSaturation> createCapillaryPressureModel( | |||
| BaseLib::ConfigTree conf(ptree, "", BaseLib::ConfigTree::onerror, | |||
| BaseLib::ConfigTree::onwarning); | |||
| auto const& sub_config = conf.getConfigSubtree("capillary_pressure"); | |||
| sub_config.ignoreConfigAttribute("id"); | |||
There was a problem hiding this comment.
Why the ignore? If for later extensions, please add a todo comment.
There was a problem hiding this comment.
Added by a mistake during the rebasing. Removed,
|
Any further comments? |
…class and changed some names with compiler reserved characters.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
1 adds a model of Curve for capillary pressure saturation,
2. changes some member names starting with an underscore and followed by a capital letter,
3. moves common members of capillary pressure saturation classes to their base class,
4. corrects some documentations.