-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a model of Curve for capillary pressure saturation #1578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
{ | ||
public: | ||
CapillaryPressureSaturationCurve( | ||
std::unique_ptr<MathLib::PiecewiseLinearMonotonicCurve>& curve_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you move from this, please use &&. (and std::move on the caller side).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Changed
@@ -32,6 +32,7 @@ std::unique_ptr<CapillaryPressureSaturation> createCapillaryPressureModel( | |||
BaseLib::ConfigTree conf(ptree, "", BaseLib::ConfigTree::onerror, | |||
BaseLib::ConfigTree::onwarning); | |||
auto const& sub_config = conf.getConfigSubtree("capillary_pressure"); | |||
sub_config.ignoreConfigAttribute("id"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the ignore? If for later extensions, please add a todo comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added by a mistake during the rebasing. Removed,
Any further comments? |
…class and changed some names with compiler reserved characters.
OpenGeoSys development has been moved to GitLab. |
This PR:
1 adds a model of Curve for capillary pressure saturation,
2. changes some member names starting with an underscore and followed by a capital letter,
3. moves common members of capillary pressure saturation classes to their base class,
4. corrects some documentations.