-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshLib add properties #542
Conversation
1594112
to
82ef22d
Compare
#include <boost/any.hpp> | ||
#include <boost/optional.hpp> | ||
|
||
#include "logog/include/logog.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is logog used somewhere in this header? ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. It is not any more necessary to include logog.hpp
, as well as boost/any.hpp
, boost/optional.hpp
and map
. I will remove them.
|
||
/// @brief Material property manager on mesh items. | ||
/// Class Properties manages scalar, vector or matrix properties. For instance | ||
/// in groundwater flow porosity is scalar property and permeabilty can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: is _a_ scalar ✅
Good documentation! 👍 |
a49df2c
to
2cf55d1
Compare
Reworked according remarks of @bilke and rebased. |
/// on the heap), see the parameter item2group_mapping, is required. | ||
/// @tparam T type of the property value | ||
/// @param name the name of the property | ||
/// @param mesh_item_type for instance node or element assigned properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
param-documentation for n_prop_groups
and item2group_mapping
are missing ✅
This commit prepares the moving the visibility of the constructor to the protected space.
0527119
to
b58d5ef
Compare
👍 |
Very nice! Two suggestions for future:
I like very much the |
OpenGeoSys development has been moved to GitLab. |
This PR is based on the discussion in PR #531:
elements via an enum class (see enum class MeshItemType).
types at run time together (see tests).