Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vtk result output; vtkdiff #692

Merged
merged 6 commits into from
Jun 9, 2015
Merged

Vtk result output; vtkdiff #692

merged 6 commits into from
Jun 9, 2015

Conversation

endJunction
Copy link
Member

Write the GroundWaterflowProcess result to vtu file.
Add vtkdiff tester (also please review the vtkdiff repository) replacing the numdiff.

The test input files now include the analytical solution. There is a python code for generating the solutions, which I would like to include too but I don't know where to put it. Ideas?

Known issues:

  • The code for writing the output shall be moved somewhere else and linked with the Process::post() function via callback.
  • Some of the LARGE*vtkdiff tests are failing because the comparison method of vtkdiff is slightly different to numdiff.

@endJunction endJunction force-pushed the VtkResultOutput branch 2 times, most recently from d1f0a84 to 1174f04 Compare June 5, 2015 21:27
@ogsbot
Copy link
Member

ogsbot commented Jun 7, 2015

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/230/

@endJunction
Copy link
Member Author

I'm changing the neumann ctest a little; that's the reason why linux-pr fails. Compilation and gtests are ok.

@bilke
Copy link
Member

bilke commented Jun 8, 2015

It compiles fine on Mac OS. Although I could not run make ctest because the file 796efdd29f55ed91c70d056a3faeb947 was not found on the server.

The python files can be placed in scripts/test/... maybe.

👍

@endJunction
Copy link
Member Author

Jenkins test this please

@ogsbot
Copy link
Member

ogsbot commented Jun 8, 2015

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/238/

@ogsbot
Copy link
Member

ogsbot commented Jun 8, 2015

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/239/

@endJunction
Copy link
Member Author

OK. Following situation:
Code compiles, the gtests are green on all platforms. On linux we also run the ctests, which are now testing the Neumann setups. The tests run through and vtkdiff compares correct fields. Only the results are different from the expected. This has nothing to do with the vtkdiff or vtk output. So I remove the tests again and will fix this issue https://github.com/ufz/ogs/issues/697.

endJunction and others added 6 commits June 8, 2015 17:35
@endJunction
[A/PL] Add vtk output instead of stream in post().
4cf631b 
Using VtuInterface to write the mesh, which will
hold the resulting data in a PropertyVector.

Remove writing to an output stream.
@endJunction
[PL] Store result in a PropertyVector for writing.
9bab45a 
The result is written into a new or an existing
mesh's PropertyVector.

Mesh object is unfortunately modified, therefor the
const specifier is omited.
@endJunction
Add vtkdiff submodule and its compilation.
efb65ce
@endJunction
Add linear 1 to -1 solution to vtu inputs.
2d2a8bd
@endJunction
Replace numdiff tests with vtkdiff tests.
ad8beff
@bilke @endJunction
Don't search for vtkdiffs path, just you its target.
282bd45
bilke added a commit that referenced this pull request Jun 9, 2015
@bilke
Merge pull request #692 from endJunction/VtkResultOutput
998e72b 
Vtk result output; vtkdiff
@bilke bilke merged commit 998e72b into ufz:master Jun 9, 2015
@endJunction endJunction deleted the VtkResultOutput branch June 9, 2015 09:59
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endJunction @ogsbot @bilke