Optimizations #695
Merged
Optimizations #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,7 +120,7 @@ void GMSHAdaptiveMeshDensity::getSteinerPoints (std::vector<GeoLib::Point*> & pn | |||
| if ((*it)->getDepth() + additional_levels > max_depth) { | |||
| additional_levels = max_depth - (*it)->getDepth(); | |||
| } | |||
| const std::size_t n_pnts_per_quad_dim (MathLib::fastpow(2, additional_levels)); | |||
| const std::size_t n_pnts_per_quad_dim = 1 << additional_levels; | |||
There was a problem hiding this comment.
Readability vs. optimization 😃
|
🍰 🍺 🎸 or ⏩ Whatever you want. |
endJunction
force-pushed
the
Optimizations
branch
from
ccc0077
to
4e1e473
Compare
|
endJunction
force-pushed
the
Optimizations
branch
from
6e3e250
to
9cb133a
Compare
|
Merged subPRs and rebased. |
|
Fixed some issues in |
In the conversion of a vtkUnstructuredGrid replace the 5*(nr of elements) GetCell() calls with vtk's provided function. The 5*(nr of elements) GetCell() calls make around 50% of total instruction spent in convertUnstructuredGrid(). For current groundwater flow simulation without the linear solver call it makes around 1/6 of total instructions.
This saves 16% of instructions in the GroundwaterFlow::init() code due to faster access in the multi-index table.
Replace two-pass method in createMeshElemPropertiesFromASCRaster untility.
In particular use shift operation.
if(TARGET ..) only works if the target is defined before this statement which was not the case. The OGS_BUILD_GUI variable is always defined.
endJunction
force-pushed
the
Optimizations
branch
from
b44cb0f
to
cf76a70
Compare
|
👍 |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctest -E diffcommand needs around 10% less time.The latter changes are touching a createMeshPropertiesFromASCRaster,
which I could not test. It seems the code is not compiling at all. Probably I miss some special flags for cmake.(Thanks to Lars for fixing compilation)Please test this.
Also the performance of VtkTextureOnSurfaceFilter should increase significantly. How can one check this? (and more important, that my changes do not break anything?) (:white_check_mark: Thanks Lars!)