[UNDERTOW-1821] Path template matched parameters should keep order #983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/UNDERTOW-1821
Replace
![Screen Shot 2020-10-26 at 10 18 51](https://user-images.githubusercontent.com/2844909/97143947-abbf0580-1774-11eb-87f9-db782e761bb3.png)
HashMap
toLinkedHashMap
inPathTemplateMatcher
. Motivation: ordered matched paths look more natural e.g. in debugging:Also in my case I needed to write a simple custom matcher: not Map (expected) equals Map (actual), but a List of matched values (cannot use
Set
, because values can be repeated).Reference implementation: spring-core
org.springframework.util.AntPathMatcher
keeps original order:Cons: in theory, updated impl will take more nanoseconds in runtime and more nanobytes in memory, but I believe if there was an intention to micro-optimise it, these should be a custom Map implementation (like Netty
HttpHeaders
)