Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload issue between obj and example objs #24

Open
blewert opened this issue Feb 20, 2021 · 0 comments
Open

Fix upload issue between obj and example objs #24

blewert opened this issue Feb 20, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@blewert
Copy link
Collaborator

blewert commented Feb 20, 2021

If you switch from uploaded object to example object, and the previous example object is the same as the new one, it doesnt update. This is because oldObjSource and oldObjPath still keep their values when set. To recreate:

  • Switch to Bunny example
  • Upload bomb.obj.
  • Switch to Bunny example. It won't update.

Or:

  • Switch to Suzanne example
  • Upload bomb.obj
  • Switch to Bunny example
  • Upload bomb.obj. It won't update.

This method of updating is pretty jank to be honest. Needs some way that redux can directly call the methods like updateObjectPath(x) or updateObjectSource(x) without relying on the componentDidUpdate method.

@blewert blewert added the bug Something isn't working label Feb 20, 2021
@blewert blewert self-assigned this Feb 20, 2021
@blewert blewert added this to To do in Features & fixes via automation Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant