Merge pull request #28 from halhen/improve_performance_with_large_data

Improve performance of generating distinct interactions
upsetjs · Jul 7, 2022 · a515fbe · a515fbe
2 parents 4b375a8 + 12f306f
commit a515fbe
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/R/data-helpers.R b/R/data-helpers.R
@@ -118,14 +118,11 @@ generateCombinationsImpl <- function(sets,
     otherSets <- Filter(function(ss) {
       !(ss$name %in% s$setNames)
     }, sets)
-    dElems <- Filter(function(e) {
-      for (o in otherSets) {
-        if (e %in% o$elems) {
-          return(FALSE)
-        }
-      }
-      TRUE
-    }, s$elems)
+
+    dElems <- s$elems
+    for (o in otherSets) {
+      dElems <- setdiff(dElems, o$elems)
+    }
 
     if (s$cardinality == length(dElems)) {
       combinations <<- c(combinations, list(s))