Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CallBuilder::fire() method to invoke() #1604

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Rename CallBuilder::fire() method to invoke() #1604

merged 3 commits into from
Jan 20, 2023

Conversation

HCastano
Copy link
Contributor

The name of this has always been a bit inconsistent to me since we're calling
CallParams::invoke and ink_env::invoke_contract under the hood.

While we're breaking stuff before the release I figured it would be a good time to make
the naming here more consistent.

@HCastano
Rename fire() method to invoke()
32f586e 
This keeps this more consistent since we're wrapping a few methods with
`invoke` in the name anyways.
@HCastano
Update CHANGELOG
8a580b1
ascjones
ascjones approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes much better 👍

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #1604 (55ed23b) into master (a83c937) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1604   +/-   ##
=======================================
  Coverage   65.65%   65.65%           
=======================================
  Files         205      205           
  Lines        6286     6286           
=======================================
  Hits         4127     4127           
  Misses       2159     2159
Impacted Files Coverage Δ
crates/env/src/call/call_builder.rs 0.00% <0.00%> (ø)
...odegen/src/generator/as_dependency/contract_ref.rs 100.00% <ø> (ø)
.../codegen/src/generator/trait_def/call_forwarder.rs 100.00% <ø> (ø)
crates/storage/traits/src/layout/impls.rs 0.00% <0.00%> (-10.00%) ⬇️
crates/allocator/src/bump.rs 89.07% <0.00%> (+1.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HCastano HCastano merged commit 72f7883 into master Jan 20, 2023
@HCastano HCastano deleted the hc-rename-fire-to-invoke branch January 20, 2023 16:24
HCastano added a commit that referenced this pull request Jan 23, 2023
@HCastano
Rename CallBuilder::fire() method to invoke() (#1604)
87ae4e0 
* Rename `fire()` method to `invoke()`

This keeps this more consistent since we're wrapping a few methods with
`invoke` in the name anyways.

* Update `CHANGELOG`

* Use actual PR number
@HCastano HCastano mentioned this pull request Jan 24, 2023
Merged
@ascjones ascjones mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HCastano @codecov-commenter @ascjones