Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sr25519_verify() #1840

Merged
merged 36 commits into from
Aug 9, 2023
Merged

Add sr25519_verify() #1840

merged 36 commits into from
Aug 9, 2023

Commits on Apr 19, 2023

  1. sr25519 signature verification

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    57c27e3 View commit details
    Browse the repository at this point in the history

  2. offchain signature verification

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    5d9cbee View commit details
    Browse the repository at this point in the history

  3. fmt

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    37fa479 View commit details
    Browse the repository at this point in the history

  4. schnorrkel optional

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    0a910e1 View commit details
    Browse the repository at this point in the history

  5. update dictionary

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    b2224d6 View commit details
    Browse the repository at this point in the history

  6. fix

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    d6a9f7c View commit details
    Browse the repository at this point in the history

  7. update changelog

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9d00c92 View commit details
    Browse the repository at this point in the history

  8. add info about unstable function usage

    @kziemianek
    kziemianek committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    da71ca2 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. missing docs

    @kziemianek
    kziemianek committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    eb93905 View commit details
    Browse the repository at this point in the history

  2. review suggestions

    @kziemianek
    kziemianek committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9ca19c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. added catch for invalid public key or signature in sr25519 verification 

    public key byte[] and/or signature byte[] may not be constructed into a PublicKey or Signature if it's in the wrong format. These errors originate from the schnorrkel library and need to be caught, otherwise it'll panic and propagate up to smart contracts in ink.
    @goastler
    goastler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9b074f1 View commit details
    Browse the repository at this point in the history

  2. switched to simple signing context in sr25519_verify fn 

    there is no need to make the context directly, we can delegate that to the schnorrkel library
    @goastler
    goastler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b4a65d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Added docs for sr25519_verify() 

    Docs + example + notes about context set to "substrate"
    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    548fe27 View commit details
    Browse the repository at this point in the history

  2. Added docs to sr25519VerifyFailed error 

    Helpful for debugging why the error has occurred, as there is only ever one of 3 reasons: invalid public key, invalid message or invalid signature
    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    53c2442 View commit details
    Browse the repository at this point in the history

  3. Added docs link to substrate sr25519 signing context

    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6ce47f4 View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b9cfbf5 View commit details
    Browse the repository at this point in the history

  5. Remove reference on message variable of sr25519_verify() 

    Not required according to clippy
    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    a33283e View commit details
    Browse the repository at this point in the history

  6. Clippy embed error in panic statement during metadata execution 

    Clippy's advice
    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    35175bb View commit details
    Browse the repository at this point in the history

  7. sr25519 verification tests 

    Tested invalid public key, invalid signature, invalid message and valid case
    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7fd25ba View commit details
    Browse the repository at this point in the history

  8. Updated sr25519_verify PR number in CHANGELOG.md

    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fda5ab1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into goastler-add-sr25519_verify

    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5ab85fc View commit details
    Browse the repository at this point in the history

  10. Fix comment to adhere to spell check in sr25519 verification tests

    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fd914df View commit details
    Browse the repository at this point in the history

  11. Merge branch 'goastler-add-sr25519_verify' of github.com:prosopo/ink_… 

    …sr25519 into goastler-add-sr25519_verify
    @goastler
    goastler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ae2c65c View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. add parity as author of sr25519 module 

    Co-authored-by: Green Baneling <[email protected]>
    @goastler @xgreenx
    goastler and xgreenx committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8866fdb View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. ignore semicolon correction in item module

    @goastler
    goastler committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    79bea8a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'goastler-add-sr25519_verify' of github.com:prosopo/ink_… 

    …sr25519 into goastler-add-sr25519_verify
    @goastler
    goastler committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d0c91cf View commit details
    Browse the repository at this point in the history

  3. add warning to docs for sr25519_verify() depending on unstable interf… 

    …aces
    @goastler
    goastler committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2aef6a8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'parity/master' into goastler-add-sr2551… 

    …9_verify
    @goastler
    goastler committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    77c6cea View commit details
    Browse the repository at this point in the history

  5. remove space typo from sr25519 docs

    @goastler
    goastler committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    97e2d23 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. remove use-ink#1741 from changelog

    @goastler
    goastler committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    cf04d6d View commit details
    Browse the repository at this point in the history

  2. added documentation to the dummy method in sr25519_verification example

    @goastler
    goastler committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c500a03 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. typo in sr25519 example contract dummy method

    @goastler
    goastler committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4c3cbc8 View commit details
    Browse the repository at this point in the history

  2. spell check fix in method doc for sr25519

    @goastler
    goastler committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    bba49ea View commit details
    Browse the repository at this point in the history

  3. spell check fix in method doc for sr25519

    @goastler
    goastler committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1810468 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. move changelog entry for use-ink#1741

    @goastler
    goastler committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    eeee6d4 View commit details
    Browse the repository at this point in the history

  2. changelog typo

    @goastler
    goastler committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    77044d2 View commit details
    Browse the repository at this point in the history