-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example which uses ext_transfer + ext_terminate #554
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
987cbe5
[chores] Fix typo: invokation ➜ invocation
cmichi 9fdb2c9
[chores] Fix typo: timstamp ➜ timestamp
cmichi cdfba99
[chores] Fix typo: ininitialized ➜ initialized
cmichi d2878b1
[env] Implement terminate_contract in off-chain env
cmichi 0295a97
[examples] Add lock-until
cmichi 09b7211
[env] Implement proper off-chain testing for ext_terminate
cmichi bfbc9ee
Apply suggestions from code review
cmichi a16c8b1
[env] Fix Environment type
cmichi fea6a03
[env] Derive Balance/AccountId from Environment
cmichi e641b8f
[env] Fix types in macro
cmichi d15bd4d
[examples] Remove lock-until
cmichi 9778815
[examples] Add contract-terminate
cmichi a4e81e2
[examples] Add contract-transfer
cmichi ed21715
[examples] Make clippy happy
cmichi efa6e90
[examples] Fix example name
cmichi 1778b48
[examples] Remove Default impls
cmichi 96b1f91
[examples] Move macro to contract-terminate/test_utils
cmichi 688faab
[env] Migrate macro to fn which gets Environment type param
cmichi d228696
[env] Add explanatory dev comment
cmichi 6c0cc5f
[examples] Allow clippy::new_without_default
cmichi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? And why not flag it as
#[ink(constructor)]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clippy made me do it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what did clippy say exactly? 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It said https://www.youtube.com/watch?v=ZXsQAXx_ao0 🙃.
Okay, actually it was this one.