9995: Judge/CA: WIP Case Worksheet #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rachelschneiderman
commented
Sep 20, 2023
rachelschneiderman
commented
added 30 commits
July 13, 2023 11:13
…n state and in the DB ;
… from state when modal is dismissed, don't refer to worksheet oin state by reference
…995-wip-case-worksheet
…995-wip-case-worksheet
mmarcotte
reviewed
Sep 21, 2023
Comment on lines
+26
to
+40
| const rawUser = await applicationContext.getPersistenceGateway().getUserById({ | ||
| applicationContext, | ||
| userId: user.userId, | ||
| }); | ||
|
|
||
| const userEntity = new User(rawUser); | ||
|
|
||
| let judgeUser; | ||
| if (userEntity.isChambersUser() && !userEntity.isJudgeUser()) { | ||
| judgeUser = await applicationContext | ||
| .getUseCaseHelpers() | ||
| .getJudgeInSectionHelper(applicationContext, { | ||
| section: userEntity.section, | ||
| }); | ||
| } |
There was a problem hiding this comment.
This looks repeated from getCaseWorksheetInteractor(...).
I will make a refactoring PR after this gets merged to consolidate.
There was a problem hiding this comment.
It is repeated! Panda squad chatted about DRY-ing this up but actually felt it would obfuscate the work being done in this endpoint more than it would help anything.
3 tasks
mmarcotte
reviewed
Sep 21, 2023
| docketNumber: cerebralTest.submittedCaseDocketNumber, | ||
| status: CASE_STATUS_TYPES.submitted, | ||
| worksheet: { | ||
| primaryIssue: 'But I don`t feel like dancin`, no sir, no dancin` today', |
There was a problem hiding this comment.
so many fun song lyrics in this pr
mmarcotte
reviewed
Sep 21, 2023
| { | ||
| docketNumber: MOCK_CASE.docketNumber, | ||
| entityName: 'CaseWorksheet', | ||
| primaryIssue: 'Superstition ain`t the way', |
mmarcotte
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.