-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9995: Judge/CA: WIP Case Worksheet #3979
9995: Judge/CA: WIP Case Worksheet #3979
Conversation
rachelschneiderman
commented
Sep 20, 2023
…n state and in the DB ;
… from state when modal is dismissed, don't refer to worksheet oin state by reference
…995-wip-case-worksheet
…995-wip-case-worksheet
const rawUser = await applicationContext.getPersistenceGateway().getUserById({ | ||
applicationContext, | ||
userId: user.userId, | ||
}); | ||
|
||
const userEntity = new User(rawUser); | ||
|
||
let judgeUser; | ||
if (userEntity.isChambersUser() && !userEntity.isJudgeUser()) { | ||
judgeUser = await applicationContext | ||
.getUseCaseHelpers() | ||
.getJudgeInSectionHelper(applicationContext, { | ||
section: userEntity.section, | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks repeated from getCaseWorksheetInteractor(...)
.
I will make a refactoring PR after this gets merged to consolidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is repeated! Panda squad chatted about DRY-ing this up but actually felt it would obfuscate the work being done in this endpoint more than it would help anything.
docketNumber: cerebralTest.submittedCaseDocketNumber, | ||
status: CASE_STATUS_TYPES.submitted, | ||
worksheet: { | ||
primaryIssue: 'But I don`t feel like dancin`, no sir, no dancin` today', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so many fun song lyrics in this pr
{ | ||
docketNumber: MOCK_CASE.docketNumber, | ||
entityName: 'CaseWorksheet', | ||
primaryIssue: 'Superstition ain`t the way', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎶 ❤️