10049 display wip cav submitted cases #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/ustaxcourt/ef-cms into 10049-display-wip-cav-submitted-cases
…ef-cms into 10049-display-wip-cav-submitted-cases
…ing case document count
…on counts to be retrieved by one lambda. Update test data
…ountOfOrdersFiledByJudgesInteractor into getCountOfCaseDocumentsFiledByJudgesInteractor, update tests
…urn order and opinion objects, remove references to deleted interactors
…tors. Replace return type for said interactors with new AggregatedEventCodesType
…0049-display-wip-cav-submitted-cases
…ReportState types
…d judgeNameToDisplayForHeader; cleaned up overloaded JudgeActivityReportFilter types
…b.com/flexion/ef-cms into 10049-display-wip-cav-submitted-cases
…-activity-report-JudgeActivityReportFilters-refactor
…0049-display-wip-cav-submitted-cases
…ef-cms into 10049-display-wip-cav-submitted-cases
…b.com/flexion/ef-cms into 10049-judge-activity-report-JudgeActivityReportFilters-refactor
…dgeActivityReportFilters-refactor 10049 judge activity report judge activity report filters refactor
…0049-display-wip-cav-submitted-cases
Absolutestunna
force-pushed
the
10049-display-wip-cav-submitted-cases
branch
from
5554299
to
c30424f
Compare
mmarcotte
reviewed
Sep 21, 2023
…b.com/flexion/ef-cms into 10049-display-wip-cav-submitted-cases
mmarcotte
reviewed
Sep 21, 2023
Comment on lines
+42
to
+73
| const { aggregations: opinionAggregationCount, total: opinionTotal } = | ||
| await applicationContext | ||
| .getPersistenceGateway() | ||
| .fetchEventCodesCountForJudges({ | ||
| applicationContext, | ||
| params: { | ||
| documentEventCodes: OPINION_EVENT_CODES_WITH_BENCH_OPINION, | ||
| endDate: searchEntity.endDate, | ||
| judges: searchEntity.judges, | ||
| startDate: searchEntity.startDate, | ||
| }, | ||
| }); | ||
|
|
||
| const computedAggregatedOpinionEventCodes = | ||
| addDocumentTypeToEventCodeAggregation(opinionAggregationCount); | ||
|
|
||
| const { aggregations: orderAggregationCount, total: orderTotal } = | ||
| await applicationContext | ||
| .getPersistenceGateway() | ||
| .fetchEventCodesCountForJudges({ | ||
| applicationContext, | ||
| params: { | ||
| documentEventCodes: JUDGE_ACTIVITY_REPORT_ORDER_EVENT_CODES, | ||
| endDate: searchEntity.endDate, | ||
| judges: searchEntity.judges, | ||
| startDate: searchEntity.startDate, | ||
| }, | ||
| }); | ||
|
|
||
| const computedAggregatedOrderEventCodes = | ||
| addDocumentTypeToEventCodeAggregation(orderAggregationCount); | ||
|
|
There was a problem hiding this comment.
This is an improvement by consolidating this into one interactor! 👏
I think we can do better by having the client call the endpoint with the event codes upon which it wants to report. So, it might make two calls for the information it needs; or more calls if sometime in the future we need to support different subsets of event codes. Perhaps other UIs will make use of this.
There was a problem hiding this comment.
No need to perform this refactor now; I will document it and open up a PR after this is merged.
mmarcotte
reviewed
Sep 21, 2023
| @@ -1,6 +1,6 @@ | |||
| import { count } from './searchClient'; | |||
|
|
|||
| export const getCountOfConsolidedCases = async ({ | |||
| export const getCountOfConsolidatedCases = async ({ | |||
mmarcotte
approved these changes
Sep 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.