[WIP] Quality of life improvements and cleanup #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused imports - Name parameters when supplying - Fix a few lint warnings - `getProofCertificateAsString` now has sensible default arguments.
|
This patch should be possible to graft on to the master branch too, I hope |
amandasystems
changed the title
|
Awesome, thanks! I backported most of the changes to master, and then merged everything into scala-2.13; with the exception of the default arguments, since the proposed values (Format.Auto) would actually cause an exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getProofCertificateAsStringnow has sensible default argumentsSyncVarwith the suggested replacement standard library JavaLinkedBlockingQueueof length 1, and fix some race conditions on the way