Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IP length not deterministic #1267

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Fix: IP length not deterministic #1267

merged 1 commit into from
Sep 11, 2021

Conversation

Loyalsoldier
Copy link
Contributor

The length of IPv4 address in Go standard library could be 16
if it is in IPv6-mapped-IPv4 format.

The length of IPv4 address in Go standard library could be 16
if it is in IPv6-mapped-IPv4 format.
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #1267 (97338cb) into master (4a174e8) will decrease coverage by 0.03%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   44.76%   44.72%   -0.04%     
==========================================
  Files         485      485              
  Lines       29539    29465      -74     
==========================================
- Hits        13222    13179      -43     
+ Misses      14912    14885      -27     
+ Partials     1405     1401       -4     
Impacted Files Coverage Δ
app/router/config.go 59.03% <ø> (-6.97%) ⬇️
common/session/session.go 70.58% <ø> (ø)
infra/conf/transport_internet.go 35.92% <ø> (ø)
transport/internet/config.pb.go 16.34% <0.00%> (ø)
app/router/condition_geoip.go 78.18% <77.14%> (-12.00%) ⬇️
transport/internet/http/dialer.go 61.17% <100.00%> (ø)
app/router/config.pb.go 23.79% <0.00%> (+1.16%) ⬆️
transport/internet/websocket/connection.go 20.18% <0.00%> (+3.66%) ⬆️
proxy/freedom/freedom.go 49.00% <0.00%> (+4.00%) ⬆️
common/buf/reader.go 88.23% <0.00%> (+5.88%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a22e94...97338cb. Read the comment docs.

@Loyalsoldier Loyalsoldier merged commit c58a372 into v2fly:master Sep 11, 2021
xiaokangwang pushed a commit that referenced this pull request Sep 27, 2021
The length of IPv4 address in Go standard library could be 16
if it is in IPv6-mapped-IPv4 format.

(cherry picked from commit c58a372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants