Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default port of Dns over Quic #1834

Closed
wants to merge 1 commit into from
Closed

Change the default port of Dns over Quic #1834

wants to merge 1 commit into from

Conversation

simpleandstupid
Copy link
Contributor

@simpleandstupid simpleandstupid commented Jun 16, 2022

InRFC9250,

4.1.1. Port Selection
By default, a DNS server that supports DoQ MUST listen for and accept
QUIC connections on the dedicated UDP port 853 (Section 8), unless
there is a mutual agreement to use another port.

By default, a DNS client desiring to use DoQ with a particular server
MUST establish a QUIC connection to UDP port 853 on the server,
unless there is a mutual agreement to use another port.

DoQ connections MUST NOT use UDP port 53. This recommendation
against use of port 53 for DoQ is to avoid confusion between DoQ and
the use of DNS over UDP [RFC1035]. The risk of confusion exists even
if two parties agreed on port 53, as other parties without knowledge
of that agreement might still try to use that port.

In the stub to recursive scenario, the use of port 443 as a mutually
agreed alternative port can be operationally beneficial, since port
443 is used by many services using QUIC and HTTP-3 and is thus less
likely to be blocked than other ports. Several mechanisms for stubs
to discover recursives offering encrypted transports, including the
use of custom ports, are the subject of ongoing work.

Copy link
Contributor

@AkinoKaede AkinoKaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you could translate the commit message to English

Copy link
Contributor

@AkinoKaede AkinoKaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DNS over QUIC client of V2Ray is a implementation of draft and needs more revisions.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1834 (4086065) into master (b4069f7) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1834      +/-   ##
==========================================
+ Coverage   38.74%   38.81%   +0.07%     
==========================================
  Files         611      615       +4     
  Lines       36162    36181      +19     
==========================================
+ Hits        14010    14044      +34     
+ Misses      20581    20571      -10     
+ Partials     1571     1566       -5     
Impacted Files Coverage Δ
app/dns/nameserver_quic.go 72.64% <100.00%> (ø)
transport/internet/system_listener.go 48.07% <0.00%> (-3.85%) ⬇️
transport/internet/system_dialer.go 46.98% <0.00%> (-2.41%) ⬇️
transport/internet/sockopt_darwin.go
transport/internet/filelocker_windows.go 0.00% <0.00%> (ø)
transport/internet/tls/config_windows.go 50.00% <0.00%> (ø)
common/buf/readv_windows.go 88.88% <0.00%> (ø)
transport/internet/sockopt_windows.go 27.90% <0.00%> (ø)
common/platform/windows.go 100.00% <0.00%> (ø)
transport/internet/kcp/connection.go 70.16% <0.00%> (+0.55%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4069f7...4086065. Read the comment docs.

@simpleandstupid simpleandstupid changed the title 更改dns over quic默认端口 Change the default port of Dns over Quic Jun 16, 2022
@AkinoKaede
Copy link
Contributor

Merged in 2614dd7

@AkinoKaede AkinoKaede closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants