Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe math rand usage #2926

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

xiaokangwang
Copy link
Contributor

This pull request replaced unsafe math rand usage with crypto/rand for passively observable random choices.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 35.65%. Comparing base (cc79bbe) to head (ee604e3).

Files Patch % Lines
common/dice/dice.go 66.66% 1 Missing and 1 partial ⚠️
infra/conf/v4/trojan.go 0.00% 1 Missing ⚠️
proxy/shadowsocks2022/encoding.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
+ Coverage   35.61%   35.65%   +0.03%     
==========================================
  Files         729      729              
  Lines       41550    41556       +6     
==========================================
+ Hits        14799    14817      +18     
+ Misses      25115    25105      -10     
+ Partials     1636     1634       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaokangwang xiaokangwang merged commit 85b04d1 into v2fly:master Mar 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants