Refinement: geodata decoder remove unnecessary GC & export methods for 3rd party #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurirei
added a commit
to org-rurirei-folk/v2ray-core
that referenced
this pull request
May 3, 2021
* uses io.ReadSeeker v2fly/v2fly#965
xiaokangwang
approved these changes
May 3, 2021
DuckSoft
reviewed
May 3, 2021
The reason why the CPU gets crazy is that too many GCs explicitly. |
Loyalsoldier
changed the title
|
may not necessary to public the emitBytes. call Decode() for thrid_party is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the performance issue of the new geodata decoder and export methods and errors to 3rd parties.