fix: matched offsetSet and offsetUnset signature #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added function signature to Repository offsetSet and offsetUnset methods to match the signature of ArrayAccess.
I'm using the library for my first real Laravel project and those two methods keep on sending deprecation warnings.
I still haven't gone too deep in php OOP but I believe adding the same signature as found on php.net wouldn't break existing codebases.
I tried it on my project by modifying the code in the vendor directory and didn't get any deprecation warnings or exceptions.
Hope it helps and thank you for the library!