Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: matched offsetSet and offsetUnset signature #30

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

Mondotosz
Copy link
Contributor

@Mondotosz Mondotosz commented Aug 30, 2022

added function signature to Repository offsetSet and offsetUnset methods to match the signature of ArrayAccess.

I'm using the library for my first real Laravel project and those two methods keep on sending deprecation warnings.
I still haven't gone too deep in php OOP but I believe adding the same signature as found on php.net wouldn't break existing codebases.

I tried it on my project by modifying the code in the vendor directory and didn't get any deprecation warnings or exceptions.

Hope it helps and thank you for the library!

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #30 (3d413c2) into master (cfd7008) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #30   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        43        43           
===========================================
  Files              5         5           
  Lines            100       100           
===========================================
  Hits             100       100           

@veelasky
Copy link
Owner

veelasky commented Sep 1, 2022

@Mondotosz thank you for your contribution..

however, you should also disable the test on php7.4 and drop support for php7.4 for this to be able to qualify for merging.

@veelasky veelasky merged commit ff4aef8 into veelasky:master Sep 1, 2022
@Mondotosz
Copy link
Contributor Author

@Mondotosz thank you for your contribution..

however, you should also disable the test on php7.4 and drop support for php7.4 for this to be able to qualify for merging.

I didn't realize it was unsupported by php7.4. Thank you for taking the time to update the pipeline accordingly.
Is it really alright to drop support for php7.4?

@veelasky
Copy link
Owner

veelasky commented Sep 4, 2022

I didn't realize it was unsupported by php7.4. Thank you for taking the time to update the pipeline accordingly. Is it really alright to drop support for php7.4?

it is time to move on, whoever run 7.4 can always restraint to the old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants