Create Default HashId instance only if needed #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To reproduce the error while installing, you can use: Which will result in: |
kohlerdominik
changed the title
veelasky
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on every boot, the "Default" HashId Instance is created. This is expensive, and in most use cases unneccessary, as this default is seldomly used, as far as I understand.
Further, when using an environment without Math-libraries for
composer require veelasky/laravel-hashid(for example the Composer container), thephp artisan package:discovercommand will fail, resulting in abortion of package discovery.This change will delay the creation of the "Default" instance until it's required for the first time.