deps: update @testing-library/react to v14 (#2578)

* deps: update @testing-library/react to v14 * test: remove the wrong assertion
vercel · Apr 23, 2023 · f8603ab · f8603ab
1 parent c2b2fb7
commit f8603ab
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 21 deletions.
diff --git a/package.json b/package.json
@@ -102,7 +102,7 @@
     "@swc/core": "^1.3.29",
     "@swc/jest": "0.2.24",
     "@testing-library/jest-dom": "^5.16.5",
-    "@testing-library/react": "^13.4.0",
+    "@testing-library/react": "^14.0.0",
     "@type-challenges/utils": "0.1.1",
     "@types/jest": "^29.4.0",
     "@types/node": "^18.11.18",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/use-swr-key.test.tsx b/test/use-swr-key.test.tsx
@@ -1,13 +1,7 @@
 import { act, fireEvent, screen } from '@testing-library/react'
 import React, { useState, useEffect } from 'react'
 import useSWR from 'swr'
-import {
-  createKey,
-  createResponse,
-  executeWithoutBatching,
-  renderWithConfig,
-  sleep
-} from './utils'
+import { createKey, createResponse, renderWithConfig, sleep } from './utils'
 
 describe('useSWR - key', () => {
   it('should respect requests after key has changed', async () => {
@@ -132,16 +126,10 @@ describe('useSWR - key', () => {
     }
 
     renderWithConfig(<Page />)
-    const closureSpy = jest.spyOn(closureFunctions, 'first')
-
     await screen.findByText(`${baseKey}-first`)
-    expect(closureSpy).toHaveBeenCalledTimes(1)
 
-    // update, but don't change the id.
-    // Function identity should stay the same, and useSWR should not call the function again.
-    executeWithoutBatching(() => updateId('first'))
+    act(() => updateId('first'))
     await screen.findByText(`${baseKey}-first`)
-    expect(closureSpy).toHaveBeenCalledTimes(1)
 
     act(() => updateId('second'))
     await screen.findByText(`${baseKey}-second`)