-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor)ui: Refactoring/simplifying TUI state #8650
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
self.next(); | ||
let mut task_list = tasks.into_iter().map(Task::new).collect::<Vec<_>>(); | ||
task_list.sort_unstable(); | ||
task_list.dedup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function needs to get finished. We're not saving the new list anywhere. We should be:
- Overwriting
task_by_status
for the list of tasks - Make sure all new task names have an entry in
tasks
so we don't crash when they produce output
crates/turborepo-ui/src/tui/app.rs
Outdated
rows: u16, | ||
cols: u16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary for this PR, but I think we'll want these bits of info to end up as part of the App
state.
It's an implicit part of the TerminalOutput
and if these values change from what TerminalOutput
was constructed with, we need to make sure all terminals are resized. Currently these values don't change, but once we tackle handling terminal resizes they will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In realizing I didn't delete any of the unneeded code in TerminalPane
I ended up getting rid of this. From my rudimentary hand-testing, I'm not seeing any problems but let me know if you find something.
Co-authored-by: Chris Olszewski <[email protected]>
finished_names.as_slice(), | ||
] | ||
.concat() | ||
pub fn task_names_in_displayed_order(&self) -> impl Iterator<Item = &str> + '_ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means the function now returns an iterator over all task names instead of an vector of them. Beneficial to us as it results in far fewer allocations (4 vector allocations + 1 allocation per task) to zero allocations.
running_names.chain(planned_names).chain(finished_names) | ||
} | ||
|
||
pub fn task_name(&self, index: usize) -> &str { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helper method to avoid the pattern &app.task_by_status.task_names_in_displayed_order(index)
that was appearing in app.rs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
let highlighted_task = self | ||
.tasks_by_status | ||
.task_name(self.selected_task_index) | ||
.to_string(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to clone this as otherwise we end up holding an immutable reference to App
which would prevent us from mutating App
to move the task from planned into starting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFGTM
I think this is a great move for unifying the state associated separating it from the rendering logic.
@@ -243,10 +466,10 @@ fn update( | |||
return Ok(Some(callback)); | |||
} | |||
Event::Tick => { | |||
app.table.tick(); | |||
// app.table.tick(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove this comment completely
} | ||
Event::UpdateTasks { tasks } => { | ||
app.update_tasks(tasks); | ||
app.table.tick(); | ||
// app.table.tick(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also remove this comment completely
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-config-turbo](https://github.com/vercel/turbo) ([source](https://github.com/vercel/turbo/tree/HEAD/packages/eslint-config-turbo)) | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/eslint-config-turbo/2.0.6/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/turbo/2.0.6/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo (eslint-config-turbo)</summary> ### [`v2.0.7`](https://github.com/vercel/turbo/releases/tag/v2.0.7): Turborepo v2.0.7 [Compare Source](https://github.com/vercel/turbo/compare/v2.0.6...v2.0.7) ##### What's Changed ##### Examples - Fix lockfile in kitchen-sink. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8666 - fix(examples): correct next.config extension in tsconfig by [@​moolcoov](https://github.com/moolcoov) in [vercel/turbo#8638 - feat(examples): add `with-nestjs` example by [@​Neosoulink](https://github.com/Neosoulink) in [vercel/turbo#8162 ##### Changelog - (refactor)ui: Refactoring/simplifying TUI state by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8650 - fix: add more windows vars to default pass through env by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8615 - Add Docker to default passthroughs list. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8690 - Add VSCode's debugger variables to default passthroughs. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8689 - update env_wildcards for SvelteKit by [@​jacksteamdev](https://github.com/jacksteamdev) in [vercel/turbo#8685 - fix constant width for checkmark by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8702 - fix(ui): respect `--output-logs` and `outputLogs` for persisting logs after TUI exits by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8612 - fix(ui): only start ui if there are tasks to run by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8703 - chore(ui): add tracing to all tui operations by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8704 - adds CLI flag for controlling tui/stream by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8714 - feat: allow opting out of required package manager by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8738 - upgrade deps to avoid conflict with next.js by [@​sokra](https://github.com/sokra) in [vercel/turbo#8750 - refactor(turborepo): derive `Opts` from `Config` by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turbo#8759 ##### New Contributors - [@​dimitropoulos](https://github.com/dimitropoulos) made their first contribution in [vercel/turbo#8674 - [@​pathliving](https://github.com/pathliving) made their first contribution in [vercel/turbo#8675 - [@​UNRULYEON](https://github.com/UNRULYEON) made their first contribution in [vercel/turbo#8679 - [@​LaPulgaaa](https://github.com/LaPulgaaa) made their first contribution in [vercel/turbo#8683 - [@​jacksteamdev](https://github.com/jacksteamdev) made their first contribution in [vercel/turbo#8685 - [@​ony3000](https://github.com/ony3000) made their first contribution in [vercel/turbo#8642 - [@​moolcoov](https://github.com/moolcoov) made their first contribution in [vercel/turbo#8638 - [@​pkellner](https://github.com/pkellner) made their first contribution in [vercel/turbo#8669 - [@​vinnymac](https://github.com/vinnymac) made their first contribution in [vercel/turbo#8637 - [@​torresgol10](https://github.com/torresgol10) made their first contribution in [vercel/turbo#8719 - [@​baileywickham](https://github.com/baileywickham) made their first contribution in [vercel/turbo#8692 - [@​LioRael](https://github.com/LioRael) made their first contribution in [vercel/turbo#8741 - [@​mischnic](https://github.com/mischnic) made their first contribution in [vercel/turbo#8767 **Full Changelog**: vercel/turbo@v2.0.6...v2.0.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/technifit/tasker).
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-config-turbo](https://github.com/vercel/turbo) ([source](https://github.com/vercel/turbo/tree/HEAD/packages/eslint-config-turbo)) | [`^2.0.6` -> `^2.0.7`](https://renovatebot.com/diffs/npm/eslint-config-turbo/2.0.6/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`^2.0.6` -> `^2.0.7`](https://renovatebot.com/diffs/npm/turbo/2.0.6/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo (eslint-config-turbo)</summary> ### [`v2.0.7`](https://github.com/vercel/turbo/releases/tag/v2.0.7): Turborepo v2.0.7 [Compare Source](https://github.com/vercel/turbo/compare/v2.0.6...v2.0.7) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v2.0.7 --> ##### What's Changed ##### Examples - Fix lockfile in kitchen-sink. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8666 - fix(examples): correct next.config extension in tsconfig by [@​moolcoov](https://github.com/moolcoov) in [vercel/turbo#8638 - feat(examples): add `with-nestjs` example by [@​Neosoulink](https://github.com/Neosoulink) in [vercel/turbo#8162 ##### Changelog - (refactor)ui: Refactoring/simplifying TUI state by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8650 - fix: add more windows vars to default pass through env by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8615 - Add Docker to default passthroughs list. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8690 - Add VSCode's debugger variables to default passthroughs. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8689 - update env_wildcards for SvelteKit by [@​jacksteamdev](https://github.com/jacksteamdev) in [vercel/turbo#8685 - fix constant width for checkmark by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8702 - fix(ui): respect `--output-logs` and `outputLogs` for persisting logs after TUI exits by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8612 - fix(ui): only start ui if there are tasks to run by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8703 - chore(ui): add tracing to all tui operations by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8704 - adds CLI flag for controlling tui/stream by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8714 - feat: allow opting out of required package manager by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8738 - upgrade deps to avoid conflict with next.js by [@​sokra](https://github.com/sokra) in [vercel/turbo#8750 - refactor(turborepo): derive `Opts` from `Config` by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turbo#8759 ##### New Contributors - [@​dimitropoulos](https://github.com/dimitropoulos) made their first contribution in [vercel/turbo#8674 - [@​pathliving](https://github.com/pathliving) made their first contribution in [vercel/turbo#8675 - [@​UNRULYEON](https://github.com/UNRULYEON) made their first contribution in [vercel/turbo#8679 - [@​LaPulgaaa](https://github.com/LaPulgaaa) made their first contribution in [vercel/turbo#8683 - [@​jacksteamdev](https://github.com/jacksteamdev) made their first contribution in [vercel/turbo#8685 - [@​ony3000](https://github.com/ony3000) made their first contribution in [vercel/turbo#8642 - [@​moolcoov](https://github.com/moolcoov) made their first contribution in [vercel/turbo#8638 - [@​pkellner](https://github.com/pkellner) made their first contribution in [vercel/turbo#8669 - [@​vinnymac](https://github.com/vinnymac) made their first contribution in [vercel/turbo#8637 - [@​torresgol10](https://github.com/torresgol10) made their first contribution in [vercel/turbo#8719 - [@​baileywickham](https://github.com/baileywickham) made their first contribution in [vercel/turbo#8692 - [@​LioRael](https://github.com/LioRael) made their first contribution in [vercel/turbo#8741 - [@​mischnic](https://github.com/mischnic) made their first contribution in [vercel/turbo#8767 **Full Changelog**: vercel/turbo@v2.0.6...v2.0.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`2.0.3` -> `2.0.7`](https://renovatebot.com/diffs/npm/turbo/2.0.3/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/turbo/2.0.3/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.0.3/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo (turbo)</summary> ### [`v2.0.7`](https://github.com/vercel/turbo/releases/tag/v2.0.7): Turborepo v2.0.7 [Compare Source](https://github.com/vercel/turbo/compare/v2.0.6...v2.0.7) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v2.0.7 --> #### What's Changed ##### Examples - Fix lockfile in kitchen-sink. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8666 - fix(examples): correct next.config extension in tsconfig by [@​moolcoov](https://github.com/moolcoov) in [vercel/turbo#8638 - feat(examples): add `with-nestjs` example by [@​Neosoulink](https://github.com/Neosoulink) in [vercel/turbo#8162 ##### Changelog - (refactor)ui: Refactoring/simplifying TUI state by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8650 - fix: add more windows vars to default pass through env by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8615 - Add Docker to default passthroughs list. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8690 - Add VSCode's debugger variables to default passthroughs. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8689 - update env_wildcards for SvelteKit by [@​jacksteamdev](https://github.com/jacksteamdev) in [vercel/turbo#8685 - fix constant width for checkmark by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8702 - fix(ui): respect `--output-logs` and `outputLogs` for persisting logs after TUI exits by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8612 - fix(ui): only start ui if there are tasks to run by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8703 - chore(ui): add tracing to all tui operations by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8704 - adds CLI flag for controlling tui/stream by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8714 - feat: allow opting out of required package manager by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8738 - upgrade deps to avoid conflict with next.js by [@​sokra](https://github.com/sokra) in [vercel/turbo#8750 - refactor(turborepo): derive `Opts` from `Config` by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turbo#8759 #### New Contributors - [@​dimitropoulos](https://github.com/dimitropoulos) made their first contribution in [vercel/turbo#8674 - [@​pathliving](https://github.com/pathliving) made their first contribution in [vercel/turbo#8675 - [@​UNRULYEON](https://github.com/UNRULYEON) made their first contribution in [vercel/turbo#8679 - [@​LaPulgaaa](https://github.com/LaPulgaaa) made their first contribution in [vercel/turbo#8683 - [@​jacksteamdev](https://github.com/jacksteamdev) made their first contribution in [vercel/turbo#8685 - [@​ony3000](https://github.com/ony3000) made their first contribution in [vercel/turbo#8642 - [@​moolcoov](https://github.com/moolcoov) made their first contribution in [vercel/turbo#8638 - [@​pkellner](https://github.com/pkellner) made their first contribution in [vercel/turbo#8669 - [@​vinnymac](https://github.com/vinnymac) made their first contribution in [vercel/turbo#8637 - [@​torresgol10](https://github.com/torresgol10) made their first contribution in [vercel/turbo#8719 - [@​baileywickham](https://github.com/baileywickham) made their first contribution in [vercel/turbo#8692 - [@​LioRael](https://github.com/LioRael) made their first contribution in [vercel/turbo#8741 - [@​mischnic](https://github.com/mischnic) made their first contribution in [vercel/turbo#8767 **Full Changelog**: vercel/turbo@v2.0.6...v2.0.7 ### [`v2.0.6`](https://github.com/vercel/turbo/releases/tag/v2.0.6): Turborepo v2.0.6 [Compare Source](https://github.com/vercel/turbo/compare/v2.0.5...v2.0.6) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v2.0.6 --> #### What's Changed ##### Examples - More fix-ups for `kitchen-sink`. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8590 - c2aa1 by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8592 - More kitchen-sink. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8593 - Fixing kitchen-sink example. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8600 - fix(turborepo): update package.json typo by [@​JannatinNaimXIII](https://github.com/JannatinNaimXIII) in [vercel/turbo#8621 ##### Changelog - fix(pnpm): enable npmrc parsing for pnpm 9 by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8591 - chore(turbo): add debug logs for changes files when using a git range filter by [@​mehulkar](https://github.com/mehulkar) in [vercel/turbo#8608 - chore(ui): disable tui as the default by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8631 - fix(ui): Use double arrow instead of spinner for active tasks. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8632 #### New Contributors - [@​kettei-sproutty](https://github.com/kettei-sproutty) made their first contribution in [vercel/turbo#8596 - [@​JannatinNaimXIII](https://github.com/JannatinNaimXIII) made their first contribution in [vercel/turbo#8613 - [@​NamesMT](https://github.com/NamesMT) made their first contribution in [vercel/turbo#8616 **Full Changelog**: vercel/turbo@v2.0.5...v2.0.6 ### [`v2.0.5`](https://github.com/vercel/turbo/compare/v2.0.4...v2.0.5) [Compare Source](https://github.com/vercel/turbo/compare/v2.0.4...v2.0.5) ### [`v2.0.4`](https://github.com/vercel/turbo/releases/tag/v2.0.4): Turborepo v2.0.4 [Compare Source](https://github.com/vercel/turbo/compare/v2.0.3...v2.0.4) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v2.0.4 --> #### What's Changed ##### create-turbo - Update `create-turbo` to use carat versions. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8448 ##### [@​turbo/codemod](https://github.com/turbo/codemod) - chore: bump timeout for migration by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8463 - fix([@​turbo/codemode](https://github.com/turbo/codemode)): no-op when turbo.json already contains tasks key by [@​mehulkar](https://github.com/mehulkar) in [vercel/turbo#8471 ##### Examples - Give examples carat versions. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8382 - Fix apk order in example. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8392 - Fix `eslint-config-turbo` configuration in examples. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8405 - Remove root eslintrc from basic example. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8423 - Consistent Node.js version in Changesets action. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8441 - Remove global dep from basic example. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8442 ##### Changelog - fix(filter): account for root internal dependencies in git based filter by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8364 - Warn instead of print when no locally installed version. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8384 - Add CI to default passthroughs. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8393 - feat(shim): invoke local turbo version via npx if not installed by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8385 - docs: update links to logs in turbo types by [@​boyum](https://github.com/boyum) in [vercel/turbo#8403 - fix: added `LD_LIBRARY_PATH` to default forwarded env vars by [@​GauBen](https://github.com/GauBen) in [vercel/turbo#8412 - chore(turborepo): remove unused code by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turbo#8428 - fix: disable panic handler in ci by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8436 - fix: remove inferring turbo version from package.json or turbo.json by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8437 - fix(turborepo): avoid starting ui on too small terminals by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turbo#8457 - chore(shim): make dynamic downloads opt in by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8458 - fix(shim): avoid panic if user has malformed lockfile by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8461 - fix(ui): pass through terminal env vars to appease chalk by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8468 #### New Contributors - [@​boyum](https://github.com/boyum) made their first contribution in [vercel/turbo#8403 - [@​GauBen](https://github.com/GauBen) made their first contribution in [vercel/turbo#8412 - [@​sethidden](https://github.com/sethidden) made their first contribution in [vercel/turbo#8450 **Full Changelog**: vercel/turbo@v2.0.3...v2.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GSTJ/react-native-magic-modal). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@prisma/client](https://www.prisma.io) ([source](https://github.com/prisma/prisma/tree/HEAD/packages/client)) | dependencies | minor | [`5.16.2` -> `5.17.0`](https://renovatebot.com/diffs/npm/@prisma%2fclient/5.16.2/5.17.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/prisma/prisma/badge)](https://securityscorecards.dev/viewer/?uri=github.com/prisma/prisma) | | [@prisma/instrumentation](https://www.prisma.io) ([source](https://github.com/prisma/prisma/tree/HEAD/packages/instrumentation)) | dependencies | minor | [`5.16.2` -> `5.17.0`](https://renovatebot.com/diffs/npm/@prisma%2finstrumentation/5.16.2/5.17.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/prisma/prisma/badge)](https://securityscorecards.dev/viewer/?uri=github.com/prisma/prisma) | | [@prisma/nextjs-monorepo-workaround-plugin](https://www.prisma.io) ([source](https://github.com/prisma/prisma/tree/HEAD/packages/nextjs-monorepo-workaround-plugin)) | devDependencies | minor | [`5.16.2` -> `5.17.0`](https://renovatebot.com/diffs/npm/@prisma%2fnextjs-monorepo-workaround-plugin/5.16.2/5.17.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/prisma/prisma/badge)](https://securityscorecards.dev/viewer/?uri=github.com/prisma/prisma) | | [@turbo/gen](https://turbo.build/repo) ([source](https://github.com/vercel/turbo/tree/HEAD/packages/turbo-gen)) | devDependencies | patch | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/@turbo%2fgen/2.0.6/2.0.7) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/vercel/turbo/badge)](https://securityscorecards.dev/viewer/?uri=github.com/vercel/turbo) | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | devDependencies | patch | [`20.14.10` -> `20.14.11`](https://renovatebot.com/diffs/npm/@types%2fnode/20.14.10/20.14.11) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/DefinitelyTyped/DefinitelyTyped/badge)](https://securityscorecards.dev/viewer/?uri=github.com/DefinitelyTyped/DefinitelyTyped) | | [eslint-plugin-turbo](https://github.com/vercel/turbo) ([source](https://github.com/vercel/turbo/tree/HEAD/packages/eslint-plugin-turbo)) | devDependencies | patch | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/eslint-plugin-turbo/2.0.6/2.0.7) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/vercel/turbo/badge)](https://securityscorecards.dev/viewer/?uri=github.com/vercel/turbo) | | [husky](https://github.com/typicode/husky) | devDependencies | minor | [`9.0.11` -> `9.1.0`](https://renovatebot.com/diffs/npm/husky/9.0.11/9.1.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typicode/husky/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typicode/husky) | | [prisma](https://www.prisma.io) ([source](https://github.com/prisma/prisma/tree/HEAD/packages/cli)) | devDependencies | minor | [`5.16.2` -> `5.17.0`](https://renovatebot.com/diffs/npm/prisma/5.16.2/5.17.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/prisma/prisma/badge)](https://securityscorecards.dev/viewer/?uri=github.com/prisma/prisma) | | [remeda](https://remedajs.com/) ([source](https://github.com/remeda/remeda)) | dependencies | minor | [`2.5.0` -> `2.6.0`](https://renovatebot.com/diffs/npm/remeda/2.5.0/2.6.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/remeda/remeda/badge)](https://securityscorecards.dev/viewer/?uri=github.com/remeda/remeda) | | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | devDependencies | patch | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/turbo/2.0.6/2.0.7) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/vercel/turbo/badge)](https://securityscorecards.dev/viewer/?uri=github.com/vercel/turbo) | | [type-fest](https://github.com/sindresorhus/type-fest) | devDependencies | minor | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/type-fest/4.21.0/4.22.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/sindresorhus/type-fest/badge)](https://securityscorecards.dev/viewer/?uri=github.com/sindresorhus/type-fest) | --- ### Release Notes <details> <summary>prisma/prisma (@​prisma/client)</summary> ### [`v5.17.0`](https://github.com/prisma/prisma/releases/tag/5.17.0) [Compare Source](https://github.com/prisma/prisma/compare/5.16.2...5.17.0) 🌟 **Help us spread the word about Prisma by starring the repo or [tweeting](https://twitter.com/intent/tweet?text=Check%20out%20the%20latest%20@​prisma%20release%20v5.17.0%20%F0%9F%9A%80%0D%0A%0D%0Ahttps://github.com/prisma/prisma/releases/tag/5.17.0) about the release.** 🌟 ##### Highlights ##### VSCode extension improvements We’re happy to introduce some cool new features that will make your experience with the Prisma VSCode extension even better! **Find references across schema files** The ability to hop between references of a given symbol is really useful in application code and now with the introduction of multi-file schema, we think it’s the perfect time to bring this feature to the VSCode extension! With the 5.17.0 release, you’ll now have the ability to use the native “find references” feature to find any usage of a given symbol ![references](https://github.com/user-attachments/assets/b7d82584-2be7-4db6-bfd9-4dbe46f9e865) **Added context on hover** When hovering over a symbol that references a view, type, enum, or any other block with multiple values, you’ll now see a handy pop out that shows what is in that block at a glance. ![image](https://github.com/user-attachments/assets/b0dbc818-374b-4b6d-bda5-974d66efca65) **Additional quick fixes** We’ve taken some fixes made by the `prisma format` cli command and made them quick fixes available to the VSCode Extension. Now, when you have forget a back relation or relation scalar field, you’ll now see in real time what is wrong and have the option to fix it via the extension. ![image (1)](https://github.com/user-attachments/assets/931e8dff-2b1e-4da7-bd17-5b844d12804e) ##### QueryRaw performance improvements We’ve changed the response format of `queryRaw` to decrease its average size which reduces serialization CPU overhead. When querying large data sets, we expect you to see improved memory usage and up to 2x performance improvements. ##### Fixes and improvements ##### Prisma Client - [Remove or change `This is the 10th instance of Prisma Client being started. Make sure this is intentional.` warning](https://github.com/prisma/prisma/issues/23736) ##### Prisma - [Prisma generate option --allow-no-models doesn't work.](https://github.com/prisma/prisma/issues/24737) ##### Language tools (e.g. VS Code) - [LSP Rename incorrectly maps field name and appends character](https://github.com/prisma/language-tools/issues/1771) ##### Credits Huge thanks to [@​key-moon](https://github.com/key-moon), [@​pranayat](https://github.com/pranayat), [@​yubrot](https://github.com/yubrot), [@​skyzh](https://github.com/skyzh) for helping! </details> <details> <summary>vercel/turbo (@​turbo/gen)</summary> ### [`v2.0.7`](https://github.com/vercel/turbo/releases/tag/v2.0.7): Turborepo v2.0.7 [Compare Source](https://github.com/vercel/turbo/compare/v2.0.6...v2.0.7) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v2.0.7 --> ##### What's Changed ##### Examples - Fix lockfile in kitchen-sink. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8666 - fix(examples): correct next.config extension in tsconfig by [@​moolcoov](https://github.com/moolcoov) in [vercel/turbo#8638 - feat(examples): add `with-nestjs` example by [@​Neosoulink](https://github.com/Neosoulink) in [vercel/turbo#8162 ##### Changelog - (refactor)ui: Refactoring/simplifying TUI state by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8650 - fix: add more windows vars to default pass through env by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8615 - Add Docker to default passthroughs list. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8690 - Add VSCode's debugger variables to default passthroughs. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turbo#8689 - update env_wildcards for SvelteKit by [@​jacksteamdev](https://github.com/jacksteamdev) in [vercel/turbo#8685 - fix constant width for checkmark by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8702 - fix(ui): respect `--output-logs` and `outputLogs` for persisting logs after TUI exits by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8612 - fix(ui): only start ui if there are tasks to run by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8703 - chore(ui): add tracing to all tui operations by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8704 - adds CLI flag for controlling tui/stream by [@​dimitropoulos](https://github.com/dimitropoulos) in [vercel/turbo#8714 - feat: allow opting out of required package manager by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turbo#8738 - upgrade deps to avoid conflict with next.js by [@​sokra](https://github.com/sokra) in [vercel/turbo#8750 - refactor(turborepo): derive `Opts` from `Config` by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turbo#8759 ##### New Contributors - [@​dimitropoulos](https://github.com/dimitropoulos) made their first contribution in [vercel/turbo#8674 - [@​pathliving](https://github.com/pathliving) made their first contribution in [vercel/turbo#8675 - [@​UNRULYEON](https://github.com/UNRULYEON) made their first contribution in [vercel/turbo#8679 - [@​LaPulgaaa](https://github.com/LaPulgaaa) made their first contribution in [vercel/turbo#8683 - [@​jacksteamdev](https://github.com/jacksteamdev) made their first contribution in [vercel/turbo#8685 - [@​ony3000](https://github.com/ony3000) made their first contribution in [vercel/turbo#8642 - [@​moolcoov](https://github.com/moolcoov) made their first contribution in [vercel/turbo#8638 - [@​pkellner](https://github.com/pkellner) made their first contribution in [vercel/turbo#8669 - [@​vinnymac](https://github.com/vinnymac) made their first contribution in [vercel/turbo#8637 - [@​torresgol10](https://github.com/torresgol10) made their first contribution in [vercel/turbo#8719 - [@​baileywickham](https://github.com/baileywickham) made their first contribution in [vercel/turbo#8692 - [@​LioRael](https://github.com/LioRael) made their first contribution in [vercel/turbo#8741 - [@​mischnic](https://github.com/mischnic) made their first contribution in [vercel/turbo#8767 **Full Changelog**: vercel/turbo@v2.0.6...v2.0.7 </details> <details> <summary>typicode/husky (husky)</summary> ### [`v9.1.0`](https://github.com/typicode/husky/compare/v9.0.11...9cef99b8213ac42656c16c059346b5c095a274ac) [Compare Source](https://github.com/typicode/husky/compare/v9.0.11...v9.1.0) </details> <details> <summary>remeda/remeda (remeda)</summary> ### [`v2.6.0`](https://github.com/remeda/remeda/releases/tag/v2.6.0) [Compare Source](https://github.com/remeda/remeda/compare/v2.5.0...v2.6.0) ##### Features - **shuffle:** Maintain input shape ([#​781](https://github.com/remeda/remeda/issues/781)) ([fde46e0](https://github.com/remeda/remeda/commit/fde46e0a755cc2e0c3b6c0c95c437295ec172501)) </details> <details> <summary>sindresorhus/type-fest (type-fest)</summary> ### [`v4.22.0`](https://github.com/sindresorhus/type-fest/compare/v4.21.0...e8d6dfefc6433254fb8ce5bcbcf5f124f6a236d9) [Compare Source](https://github.com/sindresorhus/type-fest/compare/v4.21.0...v4.22.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/InReach). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2IiwibGFiZWxzIjpbImF1dG9tZXJnZSIsImRlcGVuZGVuY2llcyIsImtvZGlhazogbWVyZ2UubWV0aG9kID0gJ3NxdWFzaCciXX0=--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description
Previously, we held the state for the TUI in the sub-components of
app.rs
. In this PR, we're hoisting those state variables up so we can have better access to that shared state and create more robust UI.Testing Instructions
There two behavioral changes in this PR:
Beyond that, you should see no behavioral changes.