Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name of the attack should flash up on screen during the attack animation #96

Open
euricaeris opened this issue Sep 18, 2018 · 3 comments

Comments

@euricaeris
Copy link
Member

I think it would be entertaining to see attack names surfaced while the attack animations are playing. Something like 'Adorable Spear' appearing in the middle of the screen with some minor movement on it, maybe some particles, before moving onto the next move.

In particular, colour-coding the attack names with the attack type, and making the particles rock/paper/scissors, could be a neat way to identify which enemies are a threat to you.

colons added a commit that referenced this issue Jun 21, 2021
cc. #96.

Not quite finished, partly because the text appears under the canvas,
which isn't ideal. Not sure what's going on there.
@theshillito
Copy link
Member

This is working now, but on three word attacks, you only see the first two words
File

Also, longer words get cropped (this is "questionable shout")
File (1)

@euricaeris
Copy link
Member Author

Three word attacks can appear for me if the character count in the attack is low enough. It only shows 2 of the 3 words 95% of the time though.

@okand
Copy link
Member

okand commented Jun 24, 2021

Only two words fit for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants