Skip to content

Commit

Permalink
Revert "load cold segments"
Browse files Browse the repository at this point in the history
This reverts commit 0c5e37d.
  • Loading branch information
gernest committed Feb 10, 2024
1 parent 1778f3f commit be880f6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 36 deletions.
9 changes: 1 addition & 8 deletions segment/cold/indes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (

"github.com/apache/arrow/go/v15/arrow/array"
"github.com/apache/arrow/go/v15/arrow/memory"
"github.com/docker/go-units"
"github.com/vinceanalytics/vince/staples"
)

Expand All @@ -21,11 +20,5 @@ func TestIndex(t *testing.T) {
if err != nil {
t.Fatal(err)
}
defer r.Release()

seg, err := New(r)
if err != nil {
t.Fatal(err)
}
t.Error(units.BytesSize(float64(seg.Size())))
t.Error(r.NumRows())
}
25 changes: 0 additions & 25 deletions segment/cold/index.go
Original file line number Diff line number Diff line change
@@ -1,26 +1 @@
package cold

import (
"github.com/apache/arrow/go/v15/arrow"
"github.com/vinceanalytics/vince/camel"
v1 "github.com/vinceanalytics/vince/gen/go/staples/v1"
"github.com/vinceanalytics/vince/segment"
"github.com/vinceanalytics/vince/segment/ice"
)

var skipFields = map[string]struct{}{
camel.Case(v1.Filters_ID.String()): {},
camel.Case(v1.Filters_Session.String()): {},
camel.Case(v1.Filters_Bounce.String()): {},
camel.Case(v1.Filters_Duration.String()): {},
}

func New(r arrow.Record) (segment.Segment, error) {
document := NewRecord(r, func(r arrow.Record, i int) bool {
_, ok := skipFields[r.ColumnName(i)]
return !ok
})
defer document.Release()
seg, _, err := ice.New([]segment.Document{document}, func(s string, i int) float32 { return 0 })
return seg, err
}
4 changes: 1 addition & 3 deletions segment/cold/record.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ func (r *Record) Release() {

func (r *Record) EachField(vf segment.VisitField) {
for i := 0; i < int(r.record.NumCols()); i++ {
if r.accept(r.record, i) {
visitArray(r.record.Column(i), r.record.ColumnName(i), vf)
}
visitArray(r.record.Column(i), r.record.ColumnName(i), vf)
}
}

Expand Down

0 comments on commit be880f6

Please sign in to comment.